Page MenuHomePhabricator

Internationalise credit line in /ve/modules/ve.ui.CitoidInspector.js in Citoid mediawiki extension
Open, Needs TriagePublic

Description

The Citoid mediawiki extension has a credit line (Powered by...") which will display either "Powered by Zotero" or "Powered by Wayback Machine."

"Powered by" is translatable, but "Zotero" and "Wayback Machine" are not.

These should be internationalised by adding new messages to qqq.json and en.json files in the i18n subdirectory and making the relevant changes to /ve/modules/ve.ui.CitoidInspector.js to pull in the messages.

You don't need to modify the other i18n files, but qqq.json is for notes/info; you might comment that although Zotero and Wayback Machine are both proper names and don't need to be translated in many Latin languages, they might need to be transliterated in some languages that use different character sets (i.e. Arabic, Russian, etc.)

See also Manual:Developing_extensions#Localisation for more on how to make messages translatable.

In order to test it is working, you will need to set up mediawiki and the Citoid extension using Docker.

You will also need to add citation templates and configure citoid in your local installation, following the directions here.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Mvolz updated the task description. (Show Details)
Mvolz added a project: I18n.
Mvolz updated the task description. (Show Details)
Mvolz updated the task description. (Show Details)
Mvolz updated the task description. (Show Details)

@Mvolz,

Hi, I’m currently working on the task to internationalize the credit line in the Citoid extension as part of my contribution to MediaWiki. However, I encountered an issue while following the task instructions.
When I cloned the Citoid repository(https://gerrit.wikimedia.org/r/mediawiki/services/citoid), I couldn't locate the files mentioned in the task:
modules/ve.ui.CitoidInspector.js, i18n
I’ve searched through the repository and could not find these files or their equivalent. Could you please clarify if these files have been moved, renamed, or if there’s an alternative file path I should be looking at?
As I’m new to contributing to MediaWiki’s codebase, any guidance you can provide would be greatly appreciated.

Could you please review my changes?Link:https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/1104042 Any feedback or suggestions would be greatly appreciated. Thank you for your time and consideration.

Could you please review my changes? Link:https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/1104386 Any feedback or suggestions would be greatly appreciated. Thank you for your time and consideration.

Hi both, thanks so much for your contributions!

As per https://www.mediawiki.org/wiki/New_Developers#Communication_tips, ideally one person would have claimed the task first using the assign button.

Additionally if someone is either assigned to the task or obviously working on a task already (i.e. has a patch already uploaded), ideally we let them either finish working on it or decide not to work on it any longer first, before someone else starts working on it.

This prevents people wasting time working on the same bug since we can only merge one patch :(. (However hopefully it's not a complete waste as we've learned something?! :))

Change #1104042 had a related patch set uploaded (by GauriGuptaa; author: GauriGuptaa):

[mediawiki/extensions/Citoid@master] citoid: Internationalize credit line in Citoid Inspector

https://gerrit.wikimedia.org/r/1104042

Change #1104386 had a related patch set uploaded (by Nischay3333; author: Nischay3333):

[mediawiki/extensions/Citoid@master] Citoid: Add internationalized messages for "Powered by" credit line

https://gerrit.wikimedia.org/r/1104386

@Mvolz please review the code as I have done the required changes.

@Mvolz done the necessary testing locally, please review change.

@Mvolz please review the changes as the bot has already passed the changes.

Change #1104042 abandoned by GauriGuptaa:

[mediawiki/extensions/Citoid@master] citoid: Internationalize credit line in Citoid Inspector

https://gerrit.wikimedia.org/r/1104042