Text in page preview changes to visited color when its article was visited before
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Hooman_Mallahzadeh
	Dec 13 2024, 1:08 PM

Description

Steps to replicate the issue (include links if applicable):

Open an article for example open Tim Berners-Lee article
Open a link in that article for example open World Wide Web
Return to the anchor article (i.e. return to the article Tim Berners-Lee)
Now hover on the Word Wide Web link
Move move into the page preview itself so you hare hovering over the summary text.

What happens?:
The summary text color changes to blue.

What should have happened instead?:
No color change is needed when hovering.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Windows, Chrome, Firefox, Opera, Edge etc.
Confirmed in Firefox and Chrome

Other information (browser name/version, screenshots, etc.):
Here is a screenshot of the problem:

The_problem_of_hovering_Screenshot.png (711×1 px, 541 KB)

Debugging information can be found here:
https://github.com/wikimedia/mediawiki-extensions-Popups?tab=readme-ov-file#debugging

The fix should be a simple case of adding the following rule:

a.mwe-popups-extract:hover {
    color: inherit;
}

to https://github.com/wikimedia/mediawiki-extensions-Popups/blob/07337b540ec152fae8af96a86c03dd83aab44922/src/ui/templates/popup/popup.less#L76

OR
Strengthening the existing .mwe-popups .mwe-popups-extract selector to .mwe-popups a.mwe-popups-extract

Requirement

Ensure that the summary text in page previews does not change color when the linked article has been previously visited. The text should maintain a consistent color regardless of the link’s visited status.

BDD

Feature: Consistent text color in page previews for visited links  
  Scenario: Text color remains unchanged when hovering over a page preview of a visited link  
    Given a user has previously visited an article  
    When the user hovers over the link to that article and moves the cursor into the page preview  
    Then the summary text color in the page preview should remain consistent and not change  

  Scenario: Text color remains unchanged for unvisited links  
    Given a user has not visited an article  
    When the user hovers over the link to that article and moves the cursor into the page preview  
    Then the summary text color in the page preview should remain consistent and not change

Test Steps

Test Case 1: Verify text color does not change for visited links

Open the Tim Berners-Lee article on Wikipedia.
Click on the World Wide Web link to visit that article.
Use the browser’s back button to return to the Tim Berners-Lee article.
Hover over the World Wide Web link to trigger the page preview.
Move the cursor into the page preview, hovering over the summary text.
Confirm that the summary text color does not change.
AC1: The summary text color remains consistent for visited links.

Test Case 2: Verify text color does not change for unvisited links

Open the Tim Berners-Lee article on Wikipedia.
Identify a link to an article that you have not visited before.
Hover over the link to trigger the page preview.
Move the cursor into the page preview, hovering over the summary text.
Confirm that the summary text color does not change.
AC2: The summary text color remains consistent for unvisited links.

QA Results - Beta

AC	Status	Details
1	✅	T382142#10537542
2	✅	T382142#10537542

QA Results - Prod

AC	Status	Details
1	✅	T382142#10542514
2	✅	T382142#10542514

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix visited link color	mediawiki/extensions/Popups	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T385744: Verify 1.44.0-wmf.16 deployment

Event Timeline

Hooman_Mallahzadeh created this task.Dec 13 2024, 1:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2024, 1:08 PM

Hooman_Mallahzadeh updated the task description. (Show Details)Dec 13 2024, 1:09 PM

Hooman_Mallahzadeh updated the task description. (Show Details)

Hooman_Mallahzadeh updated the task description. (Show Details)Dec 13 2024, 1:17 PM

We can't see that file: https://mediawiki.org/wiki/Phabricator/Help#File_visibility

Pppery unsubscribed.Dec 14 2024, 12:34 AM

In T382142#10404213, @Pppery wrote:

We can't see that file: https://mediawiki.org/wiki/Phabricator/Help#File_visibility

Hi, is the file visible now?

Aklapper renamed this task from Unnecessary color change in the case of hovering to Text in page preview changes when its article was visited before.Dec 14 2024, 5:03 PM

Aklapper added a project: Page-Previews.

Hi, is the file visible now?

Try yourself in a private browser window. :) Yes, it does - thanks!

Pppery unsubscribed.Dec 14 2024, 5:20 PM

I can't seem to replicate this issue.

Are you still experiencing this issue? If so, could you check if a gadget or user style is interfering?

I can reproduce this on https://en.wikipedia.org/wiki/Tim_Berners-Lee?safemode=1&usedebug=true using Firefox 134, hovering over "World Wide Web" and then hovering over the popup extract text, after having visited the "World Wide Web" page.
I'd assume that this might be involved:

a:where(:not([role='button'])):visited:hover {
  color:var(--color-visited--hover,#534fa3)
}

Aklapper renamed this task from Text in page preview changes when its article was visited before to Text in page preview changes to visited color when its article was visited before.Jan 15 2025, 8:58 AM

Jdlrobson added a project: Web-Team.Jan 15 2025, 4:26 PM

Jdlrobson updated the task description. (Show Details)

JScherer-WMF triaged this task as High priority.Jan 16 2025, 6:18 PM

Jdlrobson moved this task from Incoming to Q3 on the Web-Team board.Jan 16 2025, 7:01 PM