Page MenuHomePhabricator
Create Task
Maniphest T382177

mediawiki/services/parsoid/testreduce fails CI on Node 20
Closed, ResolvedPublic
Actions

Description

00:00:23.022 > eslint server client utils
00:00:23.022 
00:00:25.104 
00:00:25.104 /src/client/client.js
00:00:25.104   301:28  error  Can't resolve 'heapdump' in '/src/client'  n/no-missing-require
00:00:25.104 
00:00:25.104 ✖ 1 problem (1 error, 0 warnings)

This is blocking upgrading this repo to Node 20 in CI, and ultimately, dropping Node 18 from CI entirely, T343827

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Get rid of heapdump usage in client.js -- never used it for agesSubramanya Sastrymediawiki/services/parsoid/testreducemaster+1 -26
Zuul: [mediawiki/services/parsoid/testreduce] Disable CI for nowJforresterintegration/configmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Dec 13 2024, 7:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2024, 7:32 PM
Novem_Linguae subscribed.Dec 13 2024, 8:45 PM
Jdforrester-WMF added a project: Content-Platform-Team.Apr 23 2025, 2:53 PM
gerritbot added a comment.Apr 23 2025, 5:40 PM

Change #1138421 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/services/parsoid/testreduce] Disable CI for now

https://gerrit.wikimedia.org/r/1138421

gerritbot added a project: Patch-For-Review.Apr 23 2025, 5:40 PM
Jdforrester-WMF removed a parent task: T343827: Upgrade all CI jobs for WMF-deployed projects from Node 18 to Node 20.Apr 23 2025, 5:42 PM

No longer a blocker, as we're just disabling CI for now.

gerritbot added a comment.Apr 23 2025, 5:43 PM

Change #1138421 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/services/parsoid/testreduce] Disable CI for now

https://gerrit.wikimedia.org/r/1138421

Stashbot added a comment.Apr 23 2025, 5:43 PM

Mentioned in SAL (#wikimedia-releng) [2025-04-23T17:43:27Z] <James_F> Zuul: [mediawiki/services/parsoid/testreduce] Disable CI for now, for T382177

gerritbot added a comment.Apr 23 2025, 5:48 PM

Change #1138426 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid/testreduce@master] Get rid of heapdump usage in client.js -- never used it for ages

https://gerrit.wikimedia.org/r/1138426

gerritbot added a comment.Apr 23 2025, 10:06 PM

Change #1138426 merged by jenkins-bot:

[mediawiki/services/parsoid/testreduce@master] Get rid of heapdump usage in client.js -- never used it for ages

https://gerrit.wikimedia.org/r/1138426

Stashbot added a comment.Apr 23 2025, 10:11 PM

Mentioned in SAL (#wikimedia-releng) [2025-04-23T22:11:14Z] <James_F> Zuul: [mediawiki/services/parsoid/testreduce] Switch Node 20 CI on, for T382177

Jdforrester-WMF closed this task as Resolved.Apr 23 2025, 10:11 PM
Jdforrester-WMF assigned this task to ssastry.
Maintenance_bot removed a project: Patch-For-Review.Apr 23 2025, 10:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits