Page MenuHomePhabricator
Create Task
Maniphest T382232

[Refactor] Try to reduce the size of extractRefFromNode in References class
Closed, ResolvedPublic
Actions

Description

It's likely that we'll be working more on the Cite Parsoid code in the future. The codebase is still a quite long outcome of the cross complied JS Parsoid.

  • Extract validation / error handling: new functions for validating the attributes (name, group, etc.)
  • Extract methods
  • Reorder code according to purpose

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Extract two more methods in the large References classmediawiki/extensions/Citemaster+43 -28
Extract References::validateDir functionmediawiki/extensions/Citemaster+14 -4
Extract References::processNestedRefInRef functionmediawiki/extensions/Citemaster+35 -26
Rename generic Parsoid classes to Ref(erenceList)TagHandlermediawiki/extensions/Citemaster+12 -12
[refactor] Parsoid: Cleanup attributes name and followmediawiki/extensions/Citemaster+79 -54
[refactor] Parsoid: Clean up attributes validationmediawiki/extensions/Citemaster+60 -41
[refactor] Parsoid: Extract methods when composing a referencemediawiki/extensions/Citemaster+66 -31
[refactor] Parsoid: Rename and reorder some code for readabilitymediawiki/extensions/Citemaster+109 -109
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Dec 16 2024, 9:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2024, 9:25 AM
gerritbot added a comment.Dec 16 2024, 9:27 AM

Change #1100454 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Rename and reorder some code for readability

https://gerrit.wikimedia.org/r/1100454

gerritbot added a project: Patch-For-Review.Dec 16 2024, 9:27 AM

Change #1101453 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Extract methods when composing a reference

https://gerrit.wikimedia.org/r/1101453

WMDE-Fisch updated the task description. (Show Details)Dec 16 2024, 9:57 AM
lilients_WMDE claimed this task.Dec 16 2024, 2:00 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.
gerritbot added a comment.Dec 16 2024, 2:19 PM

Change #1100454 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Rename and reorder some code for readability

https://gerrit.wikimedia.org/r/1100454

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 16 2024, 3:00 PM
gerritbot added a comment.Dec 16 2024, 4:22 PM

Change #1104682 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/Cite@master] [refactor] Moving attributes check in a function

https://gerrit.wikimedia.org/r/1104682

gerritbot added a comment.Dec 17 2024, 9:30 AM

Change #1101453 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Extract methods when composing a reference

https://gerrit.wikimedia.org/r/1101453

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.12; 2025-01-14); removed MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Dec 17 2024, 10:00 AM
gerritbot added a comment.Dec 17 2024, 5:51 PM

Change #1105044 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/Cite@master] [WIP] [refactor] Parsoid: Cleanup attributes name and follow

https://gerrit.wikimedia.org/r/1105044

lilients_WMDE removed lilients_WMDE as the assignee of this task.Dec 19 2024, 5:18 PM
lilients_WMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.
lilients_WMDE subscribed.
lilients_WMDE added a comment.Dec 19 2024, 5:21 PM

I did the following refactoring:

  • added functions for validation of the attribute key, the attributes "name", "group" and "follow"
  • some renaming and cleanup in the comments

Currently the name validation has some issues on the logical side. The rest looks good. :)

MareikeHeuerWMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.Dec 20 2024, 9:07 AM
MareikeHeuerWMDE claimed this task.Dec 20 2024, 9:10 AM
MareikeHeuerWMDE removed MareikeHeuerWMDE as the assignee of this task.Jan 6 2025, 7:44 AM
MareikeHeuerWMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.
MareikeHeuerWMDE subscribed.
lilients_WMDE claimed this task.Jan 6 2025, 8:21 AM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.
lilients_WMDE removed lilients_WMDE as the assignee of this task.Jan 7 2025, 8:42 AM
lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Holiday-Sprint-2024-12-13 board.
gerritbot added a comment.Jan 7 2025, 4:50 PM

Change #1104682 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Clean up attributes validation

https://gerrit.wikimedia.org/r/1104682

awight added a project: WMDE-TechWish-Sprint-2025-01-08.Jan 8 2025, 1:17 PM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-01-08 board.
lilients_WMDE triaged this task as Low priority.Jan 14 2025, 2:05 PM
lilients_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jan 15 2025, 11:12 AM

Change #1105044 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [refactor] Parsoid: Cleanup attributes name and follow

https://gerrit.wikimedia.org/r/1105044

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2025, 11:31 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.13; 2025-01-21); removed MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 15 2025, 12:02 PM
MareikeHeuerWMDE claimed this task.Jan 15 2025, 12:03 PM
MareikeHeuerWMDE moved this task from Tech Review to Doing on the WMDE-TechWish-Sprint-2025-01-08 board.
lilients_WMDE added a parent task: T383787: [Epic] Refactor PHP Code in Cite Extension.Jan 15 2025, 3:24 PM
gerritbot added a comment.Jan 17 2025, 10:27 AM

Change #1112185 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [WIP] Rename generic "Ref" and "References" classes

https://gerrit.wikimedia.org/r/1112185

gerritbot added a project: Patch-For-Review.Jan 17 2025, 10:27 AM
gerritbot added a comment.Jan 17 2025, 2:15 PM

Change #1112216 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] Split extractRefFromNode function

https://gerrit.wikimedia.org/r/1112216

gerritbot added a comment.Jan 20 2025, 9:23 AM

Change #1112692 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Rename generic Parsoid classes to Ref(erenceList)TagHandler

https://gerrit.wikimedia.org/r/1112692

gerritbot added a comment.Jan 20 2025, 10:15 AM

Change #1112704 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract ReferenceListTagHandler from large References class

https://gerrit.wikimedia.org/r/1112704

gerritbot added a comment.Jan 20 2025, 10:15 AM

Change #1112692 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Rename generic Parsoid classes to Ref(erenceList)TagHandler

Reason:

See I0c1ccc8f08fa63066b5ccf0f7d7700536e4e910e instead.

https://gerrit.wikimedia.org/r/1112692

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2025-01-22.Jan 22 2025, 10:13 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-01-22 board.Jan 22 2025, 10:24 AM
lilients_WMDE moved this task from Doing to Watching / Stalled on the WMDE-TechWish-Sprint-2025-01-22 board.Jan 23 2025, 9:33 AM
ihurbain removed a project: Parsoid.Jan 23 2025, 3:30 PM
MareikeHeuerWMDE removed MareikeHeuerWMDE as the assignee of this task.Jan 27 2025, 9:21 AM
lilients_WMDE moved this task from Watching / Stalled to Sprint Backlog on the WMDE-TechWish-Sprint-2025-01-22 board.Jan 27 2025, 9:40 AM
lilients_WMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-01-22 board.
thiemowmde added a project: WMDE-TechWish-Sprint-2025-02-05.Feb 5 2025, 9:32 AM
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-02-05 board.
gerritbot added a comment.Feb 11 2025, 1:39 PM

Change #1118808 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract References::validateDir function

https://gerrit.wikimedia.org/r/1118808

gerritbot added a comment.Feb 13 2025, 3:37 PM

Change #1112216 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract References::processNestedRefInRef function

https://gerrit.wikimedia.org/r/1112216

gerritbot added a comment.Feb 13 2025, 3:56 PM

Change #1118808 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract References::validateDir function

https://gerrit.wikimedia.org/r/1118808

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.17; 2025-02-18); removed MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Feb 13 2025, 4:00 PM
WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2025-02-05 board.Feb 13 2025, 8:25 PM
WMDE-Fisch closed this task as Resolved.Feb 17 2025, 1:08 PM
gerritbot added a comment.Mar 27 2025, 4:13 PM

Change #1131771 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Extract two more methods in the large References class

https://gerrit.wikimedia.org/r/1131771

gerritbot added a comment.Mar 28 2025, 7:43 AM

Change #1131771 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Extract two more methods in the large References class

https://gerrit.wikimedia.org/r/1131771

thiemowmde edited parent tasks, added: T390960: Continue to clean up extractRefFromNode in References.php; removed: T383787: [Epic] Refactor PHP Code in Cite Extension.Apr 4 2025, 10:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits