Page MenuHomePhabricator

Chromium files break eslint tests for mediawiki
Closed, ResolvedPublic

Description

When we install Chromium it ends up something like: mediawiki-quickstart/mediawiki/chromium/linux-950341/chrome-linux

In the installation we have multiple files that do not follow our eslint rules (vk_swiftshader_icd.json, manifest.json and inspector_overlay/main.js). You can test that by first running ./run_selenium_test and the go into the mediawiki folder and run npm run test.

I wonder what's the best way to fix this, maybe install in a directory that is already ignored in .eslintignore? Maybe the vendor directory could be a thing. Need your input @Mhurd before I do anything here.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Install Chromium in vendor folder to avoid eslint failures.repos/test-platform/mediawiki-quickstart!33phedenskogchromium-installmain
Customize query in GitLab