Links in report are not URL encoded
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	1AmNobody24
	Dec 18 2024, 8:34 AM

Description

Steps to replicate the issue (include links if applicable):

Go to this report
Try opening the reported page by clicking on Draft:Why do bees build hexagonal honeycombs?

What happens?:
It opens https://en.wikipedia.org/wiki/Draft:Why_do_bees_build_hexagonal_honeycombs?

What should have happened instead?:
It should open https://en.wikipedia.org/wiki/Draft:Why_do_bees_build_hexagonal_honeycombs%3F

Other information (browser name/version, screenshots, etc.):
Looks like the question mark is the issue.

Event Timeline

1AmNobody24 created this task.Dec 18 2024, 8:34 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 18 2024, 8:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

JJMC89 moved this task from Backlog to Front end on the CopyPatrol board.Dec 18 2024, 9:15 AM

Same issue with the history link.
Also on this report It links to https://en.wikipedia.org/wiki/Customizable_IPA instead of https://en.wikipedia.org/wiki/Template:Customizable_IPA. It probably should also show Template:Customizable IPA as the report page instead of just Customizable IPA.

1AmNobody24 triaged this task as Low priority.Jan 7 2025, 7:15 AM

Aklapper renamed this task from Link Issue to Links in report are not URL encoded.Jan 7 2025, 8:01 AM

Aklapper raised the priority of this task from Low to Needs Triage.

From my very limited understanding of the code, I think that a change on Record.php is all that's needed.

TheresNoTime subscribed.Mar 4 2025, 1:22 PM

Was pointed at this task — not had the chance to test this, but a quick guess would be something like url_encoding in the twig template:

diff --git a/templates/feed.html.twig b/templates/feed.html.twig
index cee0216..1eeb308 100644
--- a/templates/feed.html.twig
+++ b/templates/feed.html.twig
@@ -20,12 +20,12 @@
{# Div for page title #}
<div class="row-div {% if has_wikiprojects %}col-sm-3{% else %}col-sm-4{% endif %} page-div">
        <strong>
-               <a href='{{ row.pageUrl }}' target="_blank" class="{{ row.pageDead ? 'text-danger' : '' }}">
+               <a href='{{ row.pageUrl|url_encode }}' target="_blank" class="{{ row.pageDead ? 'text-danger' : '' }}">
                        {{ row.pageTitle }}
                </a>
        </strong>
<div class="small">
-        <a href='{{ row.pageHistoryUrl }}' target="_blank" class="{{ row.pageDead ? 'text-danger' : '' }}">
+        <a href='{{ row.pageHistoryUrl|url_encode }}' target="_blank" class="{{ row.pageDead ? 'text-danger' : '' }}">
                {{ msg('history') }}
        </a>
{% if row.isNewPage and not(row.isPageDead) and 'delete' in user_rights %}

Links in report are not URL encodedOpen, Needs TriagePublicBUG REPORTActions

Description

Event Timeline

Links in report are not URL encoded
Open, Needs TriagePublicBUG REPORT
Actions