Page MenuHomePhabricator

Check on how the LQT->Flow conversion script works
Closed, ResolvedPublic

Description

In T381906: Decide how to make Liquid Threads "read only" the Editing team decided to convert LQT contents into Flow contents. To achieve this, we need to check if the script to convert the contents is working properly.

Goals

  • check if the script works properly, and if not, offer the necessarily fixes
  • test the script at a wikis where LQT contents are frozen (list in the parent task)

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
OpenNone
OpenNone
ResolvedTrizek-WMF
DuplicateNone
OpenNone
ResolvedTrizek-WMF
DuplicateNone
ResolvedSgs
ResolvedSgs
ResolvedTrizek-WMF
OpenNone
ResolvedMimurawil
ResolvedTchanders
In ProgressNone
OpenNone
Resolvedppelberg
DeclinedNone
OpenNone
ResolvedEsanders
ResolvedNone
ResolvedDLynch
OpenDLynch
ResolvedUrbanecm_WMF
ResolvedDLynch
ResolvedDLynch
OpenEsanders
ResolvedRyasmeen
ResolvedUrbanecm_WMF
ResolvedDLynch
ResolvedTrizek-WMF
Resolvedzoe
ResolvedRyasmeen
ResolvedBUG REPORTEtonkovidova
ResolvedTrizek-WMF
ResolvedNone
ResolvedPRODUCTION ERRORhubaishan
ResolvedTrizek-WMF
ResolvedDLynch
ResolvedTrizek-WMF
Resolvedppelberg
ResolvedQuiddity
Resolvedppelberg
Resolvedzoe
Resolvedzoe
ResolvedRyasmeen
Resolvedzoe
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedmatmarex
OpenNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Presently I'm trying to understand what effect the convertAllLqtPages.php script will do when faced with a "frozen" set of pages. If I have understood it correctly, what the script does is kind of orthogonal to whether or not the LQT pages can be edited: on a frozen wiki it will still quite happily take those pages and import them into Flow. If the intention is to have somewhere to safely do a dry-run, I don't think that would be the right way to go about it.

If by frozen you mean https://github.com/wikimedia/operations-mediawiki-config/blob/bb48e35598c79ef5dc0524973c9d3ac35336f604/wmf-config/liquidthreads.php#L6 then the script would do nothing because the way freezing is implemented is by forcibly making all LQT pages not actually LQT (wgLiquidThreadsAllowUserControl = false disables the useliquidthreads parser function).

Ah – thank you for the clarification. It sounds like it wouldn't really aid us much as a dry run, then.

Change #1156945 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/LiquidThreads@master] Misc fixes for LQT

https://gerrit.wikimedia.org/r/1156945

Change #1156952 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Flow@master] Fix misc stuff in LQT import code

https://gerrit.wikimedia.org/r/1156952

Change #1156959 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Flow@master] Do not try to import pages that already redirect to Flow

https://gerrit.wikimedia.org/r/1156959

Change #1156945 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Do not throw an InvalidArgumentException enumerating threads

https://gerrit.wikimedia.org/r/1156945

Change #1156952 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Fix misc stuff in LQT import code

https://gerrit.wikimedia.org/r/1156952

Change #1156959 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Do not try to import pages that already redirect to Flow

https://gerrit.wikimedia.org/r/1156959

hye @zoe – can you please update this ticket to reflect the current status of this work?

Not Zoe, but my understanding is that once T397426 is done (and the community is informed etc.) you should be ready to run LQT conversions on ptwikibooks without any further prep work.

I tested that the code works as it should and submitted a few patch fixes above, and was (IIRC) satisfied after that.

@Pppery: my plan for this morning involved asking you what you thought, and you're way ahead of me!

@ppelberg: I think we can close this one, then?

ppelberg claimed this task.

@Pppery: my plan for this morning involved asking you what you thought, and you're way ahead of me!

@ppelberg: I think we can close this one, then?

Sounds great; let's do it.