Page MenuHomePhabricator

jump-to-nav display none strangeness
Closed, InvalidPublic


Copying from

If I recall correctly, the hiding-method was changed in 1.18 or 1.19 because display: none; had side-effects defeating its very purpose! Screenreaders are given a link that jumps to #jump-to-nav. However browsers can't scroll to a section that has no place in the rendering, it has to have a place in the document structure and also in the visual rendering (so that the browser can calculate to which pixel it should scroll). The element can be transparant and only 1x1px in size, but it must not be display: none;. This new hiding method was apparently only tested in Vector and works there, but it needs fixing in Monobook (or perhaps a different hiding method that doesn't cause this problem in Monobook). Either way, using display: none; (as you did now) is not an acceptable solution in the long term. It's okay for now since it is an understandable decision to prioritize the ability for most people to click the navigation links at all, then to allow the smaller part of the population to be able to skip to the navigation using screenreaders, but really both are important groups so this should be fixed soon and this local change reverted.

This bug may be a duplicate of T36893.



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:24 AM
bzimport set Reference to bz36247.
bzimport added a subscriber: Unknown Object (MLST).

The English Wiktionary is currently having this problem because they haven't set display:none; on the #jump-to-nav element:

Aklapper lowered the priority of this task from Medium to Low.Mar 25 2015, 4:07 PM
matmarex claimed this task.
matmarex subscribed.

I'm not sure what this task is saying. Clearly I'm missing some context from six years ago, and no one at the time thought to post any screenshots of the bug they were seeing.

Right now I have no problems clicking the "discussion" link on, even though it does not have display: none set on #jump-to-nav:

image.png (520×1 px, 184 KB)

Thus I'm marking this as Invalid and recommending that you just remove the display: none hack from Meta and any other wikis it was applied on.