Page MenuHomePhabricator

Installer has no spacing between links in checkbox labels on extension list
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Run installer
  • Click "ask me more questions" at the prompt
  • Go to the extension selection page
  • Look at an extension that requires another extension

What happens?:

The label shows up like:

OpenIDConnect (requiresPluggableAuth) (more information)

with no space between requires and the required extension.

I think this is due to codex adding the display:inline-flex attribute. There is an actual space in the HTML source code.

See screenshot

mwinstaller-2.png (666×97 px, 17 KB)

What should have happened instead?:
There should be a space

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
current master (3ebe31bb069054af6f1130531d865b4c806e0b2f)

Other information (browser name/version, screenshots, etc.):

Firefox 115.14.0esr

mwinstaller-2.png (666×97 px, 17 KB)

Not sure if this is a codex bug, if different css should be applied, or if the space should be changed to a non-breaking space or something.

Possibly a regression from T337435

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think this is happening because we changed the markup for CSS-only Checkboxes a couple of times since the installer was updated to use Codex. We thought the changes were backwards-compatible but it's possible we missed something. It seems like a style is getting applied to the wrong element.

To fix this, I recommend the markup in the installer be updated to reflect the new structure. Tagging @Ladsgroup, who I believe did the original installer update, in case there's any additional context I'm missing.

@AnneT Is there a place to explain what has changed in css-only checkboxes since I used them in the installer? To make sure I do the change correctly.

@Ladsgroup Compare the example under "markup structure" (you have to click "Show code" to see the code) for the old version vs the current version. There are three changes:

  • The root element (with the cdx-checkboxclass) is now a <div>, instead of a <span>
  • A wrapper div (cdx-checkbox__wrapper) was added
  • The label structure is more elaborate: instead of a plain <label> tag with text in it, it's now a <div> containing a <label> containing a <span>

Thanks. I will try to tackle it but my plate is full right now. I don't assign it to myself to avoid cookie licking.

Change #1109523 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] installer: Adapt web installer with the codex changes

https://gerrit.wikimedia.org/r/1109523

Change #1109523 merged by jenkins-bot:

[mediawiki/core@master] installer: Adapt web installer with recent Codex changes

https://gerrit.wikimedia.org/r/1109523

Ladsgroup claimed this task.