Page MenuHomePhabricator
Create Task
Maniphest T382629

Trustly ACH recurring (gravy) that are cancelled on the donors end are breaking the charge job
Closed, ResolvedPublic
Actions

Description

Three of these happened 2024-12-20:

invoice_id : 222102261.2
gravy id: 0826a7f9-70ac-4b4b-8ace-dea4d9075d7e

/var/log/process-control/recurring_smashpig_charge/recurring_smashpig_charge-20241220-102101.log
2024-12-20 10:25:14,095 ERROR civicrm.wmf.INFO: Error: 1000009 invoice_id:222102261.2
2024-12-20 10:25:14,096 ERROR WD php: Error: Object of class [error]
2024-12-20 10:25:14,096 ERROR SmashPig\PaymentProviders\Responses\ApprovePaymentResponse could not
2024-12-20 10:25:14,096 ERROR be converted to string in
2024-12-20 10:25:14,096 ERROR CRM_Core_Payment_SmashPigRecurringProcessor->createActivity() (line
2024-12-20 10:25:14,096 ERROR 372 of
2024-12-20 10:25:14,096 ERROR /srv/org.wikimedia.civicrm/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php).
2024-12-20 10:25:14,097 INFO Error: Object of class SmashPig\PaymentProviders\Responses\ApprovePaymentResponse could not be converted to string in CRM_Core_Payment_SmashPigRecurringProcessor->createActivity() (line 372 of /srv/org.wikimedia.civicrm/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php).
2024-12-20 10:25:14,097 ERROR Drush command terminated abnormally due to an unrecoverable error. [error]

2 Failed the inital recurring setup, and then when we tried to charge the token we got the error splitToken is not valid
1 Had the inital go through but the donor cancelled it on their end after that we got the error canceled_payment_method

This is due to the ACH flow where we put them all in civi first then figure out if they succeed/fail

Details

SubjectRepoBranchLines +/-
Add small guard clause to getErrorText() to handle broken input.wikimedia/fundraising/crmmaster+16 -5
Create getErrorText and test Also fix it to handle ApprovePaymentMethodwikimedia/fundraising/crmmaster+69 -15
Customize query in gerrit

Related Objects

Event Timeline

Cstone created this task.Dec 20 2024, 11:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2024, 11:17 PM
AKanji-WMF triaged this task as High priority.Jan 13 2025, 9:31 PM
AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.
AKanji-WMF added a project: Fundraising Tech - Chaos Crew.
jgleeson subscribed.Jan 20 2025, 1:03 PM

We had another one of these today

Cstone added a comment.Jan 21 2025, 8:55 PM

I cancelled the 4 that got stuck in Processing

Damilare claimed this task.Jan 22 2025, 1:33 PM
Damilare moved this task from Backlog to User Bug Backlog on the Fundraising Tech - Chaos Crew board.
Damilare moved this task from User Bug Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
Damilare added a comment.EditedJan 22 2025, 2:37 PM

We had another set today, most of the ones I've seen follow a pattern:

The theory is:

  • Donor put in a transaction and sets up recurring
  • Along the way the payment method was cancelled (either by Trustly or the donor)
  • Civi did not acknowledge the canceled payment method and tries to charge the saved token. This leads to the error "Invalid split token"

I believe the solution would be to:

  • Listen to cancel payment method messages and cancel recurring records. From the logs, gravy has not been sending a cancel payment method message. We only have the payment error response for alerting, we could use this payment error to cancel a recurring row.
  • Given we save ACH transactions before they're settled, we should cancel the recurring record and set contribution to failed/chargeback when ACH the authorization or capture fails.
gerritbot added a comment.Jan 23 2025, 2:41 AM

Change #1113602 had a related patch set uploaded (by Cstone; author: Cstone):

[wikimedia/fundraising/crm@master] WIP: Create getErrorMesageText and test Also fix it to handle ApprovePaymentMethod

https://gerrit.wikimedia.org/r/1113602

gerritbot added a project: Patch-For-Review.Jan 23 2025, 2:41 AM
Damilare mentioned this in T384593: Create chargeback and cancel recurring on failed Trustly ACH payments.Jan 23 2025, 12:12 PM
Cstone updated the task description. (Show Details)Jan 27 2025, 4:12 PM
gerritbot added a comment.Jan 28 2025, 11:01 AM

Change #1114677 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Add small guard clause to getErrorText() to handle broken input.

https://gerrit.wikimedia.org/r/1114677

gerritbot added a comment.Jan 28 2025, 11:24 AM

Change #1113602 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Create getErrorText and test Also fix it to handle ApprovePaymentMethod

https://gerrit.wikimedia.org/r/1113602

gerritbot added a comment.Jan 28 2025, 5:39 PM

Change #1114677 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add small guard clause to getErrorText() to handle broken input.

https://gerrit.wikimedia.org/r/1114677

Damilare moved this task from In Progress to Done on the Fundraising Tech - Chaos Crew board.Feb 11 2025, 8:31 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 9:30 PM
XenoRyet closed this task as Resolved.Feb 24 2025, 8:41 PM
XenoRyet set Final Story Points to 4.
Damilare mentioned this in T386137: 2025 Sprint C Priorities / End of sprint summary.Feb 25 2025, 9:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits