Page MenuHomePhabricator
Create Task
Maniphest T382773

"tag_excludes" in AutoEdits configuration does not behave as expected
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • The edit list contains tools such as RedWarn and Twinkle, which are contained in tag_excludes for the Undo tool at https://meta.wikimedia.org/wiki/MediaWiki:XTools-AutoEdits.json
  • (It is verified by counting pages that the number shown in the "autoedits" tool does align with the number of edits that are displayed with "autoedits-contributions".)

What should have happened instead?:

  • Those edits should have been ignored for the selected tool.

Related Objects

Event Timeline

1234qwer1234qwer4 created this task.Dec 26 2024, 11:52 AM
Bunnypranav subscribed.Dec 26 2024, 11:55 AM
1234qwer1234qwer4 updated the task description. (Show Details)Dec 26 2024, 11:56 AM
Bunnypranav added a comment.Dec 26 2024, 11:57 AM

Same for Rollback and RedWarn. See https://xtools.wmcloud.org/autoedits-contributions/en.wikipedia.org/Bunnypranav/all?tool=Generic+rollback and https://xtools.wmcloud.org/autoedits-contributions/en.wikipedia.org/Bunnypranav/all?tool=RedWarn.

MusikAnimal subscribed.Jan 4 2025, 11:01 PM

Thanks for reporting! I'll try to look into this over the coming weeks, but no promises. I'm swamped with other priorities at the moment.

Cyberdog958 subscribed.Jan 7 2025, 9:49 AM
Alien333 subscribed.May 26 2025, 9:47 AM
Alien333 changed the task status from Open to In Progress.EditedMay 26 2025, 2:30 PM
Alien333 claimed this task.

We're currently not using tag_excludes, apparently. EDIT: for some things we do, but badly. (NOT IN doesn't work when there's only one, gotta NOT EXISTS SELECT 1 ...)

Bunnypranav added a comment.May 26 2025, 2:49 PM

Thanks @Alien333 for claiming this 😄, hope the fix can be implemented soon.

Alien333 added a comment.May 26 2025, 2:55 PM

I'm also correcting the table in autoedits to use tag_excludes too while we're at it, for consistency's sake if nothing else.

Alien333 added a comment.May 26 2025, 3:12 PM

There we go: PR #533. Will probably go out in the next deployment or two. Right now the bottleneck to deployment is reviews, as I'm fixing a lot of stuff and MusikAnimal's busy these days. So for the time frame it will be whenever they get the time to review.

Alien333 mentioned this in T191133: AutoEdits: Wrong classification: "Generic rollback" is shown instead of "Huggle" for Huggle 3 contributions.May 26 2025, 8:19 PM
Bunnypranav added a comment.Aug 14 2025, 1:56 PM

@MusikAnimal Could you possibly look into this PR? Thanks! :)

Restricted Repository Identity mentioned this in rXTbf4c5ef3ae20: AutoEdits: actually use `tag_excludes` correctly (#533).Aug 19 2025, 7:37 AM
MusikAnimal moved this task from Automated Edits to Pending deployment on the XTools board.Aug 19 2025, 7:37 AM

Sorry for the long wait :(

Bunnypranav added a comment.EditedAug 19 2025, 11:48 AM

@MusikAnimal Could you tell when will the patch be (auto)deployed?

Thanks for the merge!

Alien333 added a comment.Aug 19 2025, 7:35 PM
In T382773#11097986, @Bunnypranav wrote:

Could you tell when will the patch be (auto)deployed?

Normally we should have a new release (and so deployment) in the next few days.

Bunnypranav added a comment.EditedAug 20 2025, 1:20 AM

Cool, thank!

MusikAnimal closed this task as Resolved.Aug 20 2025, 10:14 PM
MusikAnimal moved this task from Pending deployment to Complete on the XTools board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits