Page MenuHomePhabricator
Create Task
Maniphest T382848

TempUserCreatorTest fails since 2025
Closed, ResolvedPublicBUG REPORT
Actions

Description

Integration tests are failing because of hard-coded year numbers in tests/phpunit/integration/includes/user/TempUser/TempUserCreatorTest.php.

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php74/17613/console

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
TempAccounts: Set fake timestamps for TempUserCreatorTestmediawiki/coreREL1_42+115 -0
TempAccounts: Set fake timestamps for TempUserCreatorTestmediawiki/coreREL1_43+10 -7
TempAccounts: Set fake timestamps for TempUserCreatorTestmediawiki/coremaster+10 -7
TempAccounts: Replace fixed year numbers in TempUserCreatorTestmediawiki/coreREL1_39+160 -0
Customize query in gerrit

Event Timeline

XtexChooser created this task.Jan 1 2025, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 1 2025, 1:11 AM
gerritbot added a comment.Jan 1 2025, 1:17 AM

Change #1107570 had a related patch set uploaded (by XtexChooser; author: XtexChooser):

[mediawiki/core@master] TempAccounts: Replace fixed year numbers in TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107570

gerritbot added a project: Patch-For-Review.Jan 1 2025, 1:17 AM
gerritbot added a comment.Jan 1 2025, 1:19 AM

Change #1107571 had a related patch set uploaded (by XtexChooser; author: XtexChooser):

[mediawiki/core@REL1_39] TempAccounts: Replace fixed year numbers in TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107571

gerritbot added a comment.Jan 1 2025, 1:21 AM

Change #1107571 abandoned by XtexChooser:

[mediawiki/core@REL1_39] TempAccounts: Replace fixed year numbers in TempUserCreatorTest

Reason:

1.39 is not affected.

https://gerrit.wikimedia.org/r/1107571

Pppery added a project: Temporary accounts.Jan 1 2025, 1:26 AM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 1 2025, 1:26 AM
XtexChooser updated the task description. (Show Details)Jan 1 2025, 1:27 AM
Urbanecm triaged this task as High priority.Jan 1 2025, 2:32 AM
Urbanecm subscribed.

Thanks for the catch (and for the fix)! I've +2'ed the patch you uploaded.

gerritbot added a comment.Jan 1 2025, 2:52 AM

Change #1107570 merged by jenkins-bot:

[mediawiki/core@master] TempAccounts: Set fake timestamps for TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107570

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 1 2025, 3:00 AM
gerritbot added a comment.Jan 1 2025, 3:01 AM

Change #1107573 had a related patch set uploaded (by XtexChooser; author: XtexChooser):

[mediawiki/core@REL1_43] TempAccounts: Set fake timestamps for TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107573

XtexChooser claimed this task.Jan 1 2025, 3:07 AM
gerritbot added a comment.Jan 1 2025, 11:21 AM

Change #1107573 merged by jenkins-bot:

[mediawiki/core@REL1_43] TempAccounts: Set fake timestamps for TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107573

Maintenance_bot removed a project: Patch-For-Review.Jan 1 2025, 11:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes.Jan 1 2025, 12:00 PM
gerritbot added a comment.Jan 2 2025, 7:58 PM

Change #1107968 had a related patch set uploaded (by Umherirrender; author: XtexChooser):

[mediawiki/core@REL1_42] TempAccounts: Set fake timestamps for TempUserCreatorTest

https://gerrit.wikimedia.org/r/1107968

gerritbot added a project: Patch-For-Review.Jan 2 2025, 7:58 PM
gerritbot added a comment.Jan 2 2025, 8:17 PM

Change #1107968 abandoned by Umherirrender:

[mediawiki/core@REL1_42] TempAccounts: Set fake timestamps for TempUserCreatorTest

Reason:

The patch set in question is I99d5973498a89ac227847de5837c0a8e895c28fb and that is REL1_43, that why this does not need backport (but the test was first added in REL1_42, so I have assumed that is needed).

It was not easy to see as the default of 'useYear' => true is in TempUserTestTrait::enableAutoCreateTempUser, so this can happen each new gregorian calender when tests aquire temp names via provider and assert against that name

https://gerrit.wikimedia.org/r/1107968

Umherirrender closed this task as Resolved.Jan 2 2025, 8:17 PM
Umherirrender removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits