Page MenuHomePhabricator
Create Task
Maniphest T382864

1.43: Error: Call to undefined method SkinNimbus::footerLink()
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • install skin on MW 1.43 (REL1_43 branch)
  • try to load the wiki using Nimbus

What happens?:

`MediaWiki internal error.

Original exception: [ba55025480470a7e9ff132e3] /index.php?title=Main_Page&useskin=nimbus Error: Call to undefined method SkinNimbus::footerLink()
Backtrace:
from /data/project/skins/public_html/skins/Nimbus/includes/SkinNimbus.php(40)
#0 /data/project/skins/public_html/skins/Nimbus/includes/SkinNimbus.php(117): SkinNimbus->specialPagesLink()
#1 /data/project/skins/public_html/includes/skins/SkinTemplate.php(156): SkinNimbus->prepareQuickTemplate()
#2 /data/project/skins/public_html/includes/skins/SkinTemplate.php(180): SkinTemplate->generateHTML()
#3 /data/project/skins/public_html/includes/skins/Skin.php(683): SkinTemplate->outputPage()
#4 /data/project/skins/public_html/includes/Output/OutputPage.php(3193): Skin->outputPageFinal()
#5 /data/project/skins/public_html/includes/actions/ActionEntryPoint.php(163): MediaWiki\Output\OutputPage->output()
#6 /data/project/skins/public_html/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#7 /data/project/skins/public_html/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#8 {main}

Exception caught inside exception handler: [ba55025480470a7e9ff132e3] /index.php?title=Main_Page&useskin=nimbus Error: Call to undefined method SkinNimbus::footerLink()
Backtrace:
from /data/project/skins/public_html/skins/Nimbus/includes/SkinNimbus.php(40)
#0 /data/project/skins/public_html/skins/Nimbus/includes/SkinNimbus.php(117): SkinNimbus->specialPagesLink()
#1 /data/project/skins/public_html/includes/skins/SkinTemplate.php(156): SkinNimbus->prepareQuickTemplate()
#2 /data/project/skins/public_html/includes/skins/SkinTemplate.php(180): SkinTemplate->generateHTML()
#3 /data/project/skins/public_html/includes/skins/Skin.php(683): SkinTemplate->outputPage()
#4 /data/project/skins/public_html/includes/Output/OutputPage.php(3193): Skin->outputPageFinal()
#5 /data/project/skins/public_html/includes/exception/MWExceptionRenderer.php(190): MediaWiki\Output\OutputPage->output()
#6 /data/project/skins/public_html/includes/exception/MWExceptionRenderer.php(109): MWExceptionRenderer::reportHTML()
#7 /data/project/skins/public_html/includes/exception/MWExceptionHandler.php(135): MWExceptionRenderer::output()
#8 /data/project/skins/public_html/includes/exception/MWExceptionHandler.php(239): MWExceptionHandler::report()
#9 /data/project/skins/public_html/includes/MediaWikiEntryPoint.php(222): MWExceptionHandler::handleException()
#10 /data/project/skins/public_html/includes/actions/ActionEntryPoint.php(82): MediaWiki\MediaWikiEntryPoint->handleTopLevelError()
#11 /data/project/skins/public_html/includes/MediaWikiEntryPoint.php(206): MediaWiki\Actions\ActionEntryPoint->handleTopLevelError()
#12 /data/project/skins/public_html/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#13 {main}`

What should have happened instead?:

skin should work without an error

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): MW 1.43 Nimbus is on latest REL1_43

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Provide a local copy of footerLink() to avoid fatals on MW 1.40+ and to make CI happymediawiki/skins/NimbusREL1_43+47 -0
Customize query in gerrit

Event Timeline

MacFan4000 created this task.Jan 2 2025, 12:20 AM
Restricted Application added a project: User-MacFan4000. · View Herald TranscriptJan 2 2025, 12:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MacFan4000 updated the task description. (Show Details)Jan 2 2025, 12:29 AM
MacFan4000 updated the task description. (Show Details)
Bugreporter2 renamed this task from fatel in MW 1.43 to fatal error in MW 1.43.Jan 2 2025, 4:43 AM
Bugreporter2 updated the task description. (Show Details)
Aklapper renamed this task from fatal error in MW 1.43 to 1.43: Error: Call to undefined method SkinNimbus::footerLink().Jan 2 2025, 9:09 AM
MacFan4000 added a comment.Jan 9 2025, 8:45 PM

Per the release notes "Skin::footerLink(), deprecated in 1.40, has been removed", so this usage will need to be replaced.

MacFan4000 added a comment.Jan 9 2025, 8:48 PM
In T382864#10445934, @MacFan4000 wrote:

Per the release notes "Skin::footerLink(), deprecated in 1.40, has been removed", so this usage will need to be replaced.

Actually looks like it just wasn't backported.

gerritbot added a comment.Jan 9 2025, 8:51 PM

Change #1109491 had a related patch set uploaded (by MacFan4000; author: Jack Phoenix):

[mediawiki/skins/Nimbus@REL1_43] Provide a local copy of footerLink() to avoid fatals on MW 1.40+ and to make CI happy

https://gerrit.wikimedia.org/r/1109491

gerritbot added a project: Patch-For-Review.Jan 9 2025, 8:51 PM
gerritbot added a comment.Jan 20 2025, 9:15 AM

Change #1109491 merged by jenkins-bot:

[mediawiki/skins/Nimbus@REL1_43] Provide a local copy of footerLink() to avoid fatals on MW 1.40+ and to make CI happy

https://gerrit.wikimedia.org/r/1109491

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2025, 9:30 AM
MacFan4000 closed this task as Resolved.Jan 28 2025, 11:34 PM
MacFan4000 claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits