InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field bt_id
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 2 2025, 12:15 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

dom_walden

tstarling

Description

What is the problem?

When creating a new block via the API, I get the following exception in the logs:

2025-01-02 11:50:52 c701508a76c8 enwiki: [7ce0c2725f3de2fb9cf3cbd5] /w/api.php   InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field bt_id
#0 /var/www/html/w/includes/libs/rdbms/platform/SQLPlatform.php(1634): Wikimedia\Rdbms\Platform\SQLPlatform->makeList()
#1 /var/www/html/w/includes/libs/rdbms/database/Database.php(1525): Wikimedia\Rdbms\Platform\SQLPlatform->updateSqlText()
#2 /var/www/html/w/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->update()
#3 /var/www/html/w/includes/libs/rdbms/database/DBConnRef.php(413): Wikimedia\Rdbms\DBConnRef->__call()
#4 /var/www/html/w/includes/libs/rdbms/querybuilder/UpdateQueryBuilder.php(335): Wikimedia\Rdbms\DBConnRef->update()
#5 /var/www/html/w/includes/block/DatabaseBlockStore.php(899): Wikimedia\Rdbms\UpdateQueryBuilder->execute()
#6 /var/www/html/w/includes/block/DatabaseBlockStore.php(872): MediaWiki\Block\DatabaseBlockStore->releaseTargets()
#7 /var/www/html/w/includes/block/DatabaseBlockStore.php(767): MediaWiki\Block\DatabaseBlockStore->deleteBlockRows()
#8 /var/www/html/w/includes/deferred/AutoCommitUpdate.php(47): MediaWiki\Block\DatabaseBlockStore->MediaWiki\Block\{closure}()
#9 /var/www/html/w/includes/deferred/DeferredUpdates.php(462): MediaWiki\Deferred\AutoCommitUpdate->doUpdate()
#10 /var/www/html/w/includes/deferred/DeferredUpdates.php(204): MediaWiki\Deferred\DeferredUpdates::attemptUpdate()
#11 /var/www/html/w/includes/deferred/DeferredUpdates.php(291): MediaWiki\Deferred\DeferredUpdates::run()
#12 /var/www/html/w/includes/deferred/DeferredUpdatesScope.php(243): MediaWiki\Deferred\DeferredUpdates::MediaWiki\Deferred\{closure}()
#13 /var/www/html/w/includes/deferred/DeferredUpdatesScope.php(172): MediaWiki\Deferred\DeferredUpdatesScope->processStageQueue()
#14 /var/www/html/w/includes/deferred/DeferredUpdates.php(310): MediaWiki\Deferred\DeferredUpdatesScope->processUpdates()
#15 /var/www/html/w/includes/MediaWikiEntryPoint.php(307): MediaWiki\Deferred\DeferredUpdates::doUpdates()
#16 /var/www/html/w/includes/MediaWikiEntryPoint.php(190): MediaWiki\MediaWikiEntryPoint->commitMainTransaction()
#17 /var/www/html/w/includes/MediaWikiEntryPoint.php(173): MediaWiki\MediaWikiEntryPoint->doPrepareForOutput()
#18 /var/www/html/w/includes/MediaWiki.php(90): MediaWiki\MediaWikiEntryPoint->prepareForOutput()
#19 /var/www/html/w/includes/api/ApiMain.php(972): MediaWiki::preOutputCommit()
#20 /var/www/html/w/includes/api/ApiMain.php(915): MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#21 /var/www/html/w/includes/api/ApiEntryPoint.php(153): MediaWiki\Api\ApiMain->execute()
#22 /var/www/html/w/includes/MediaWikiEntryPoint.php(201): MediaWiki\Api\ApiEntryPoint->execute()
#23 /var/www/html/w/api.php(44): MediaWiki\MediaWikiEntryPoint->run()
#24 {main}

I have not seen this when I am updating an existing block or with multiblocks disabled.

Steps to reproduce problem

Via the API, create a block against a user who is not blocked or a new block against an already blocked user
For example, assuming you are testing in a local docker environment and in LocalSettings.php $wgEnableMultiBlocks = true;:
Go to Special:ApiSandbox#action=block
Click the "action=block" tab
In the "user" parameter, enter a username or IP
Check the "newblock" parameter
Click "Auto-fill token" and submit
Open <mediawiki directory>/cache/mw-error.log to see the exception

Environment

Wiki(s): local docker MediaWiki 1.44.0-alpha (ec80a6a) 07:05, 2 January 2025.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	block: Fix exception when purging multiple expired blocks for the same target	mediawiki/core	master	+47 -1

Customize query in gerrit

Related Objects

Mentioned In: T378147: Block API: Add support for multiblocks
Mentioned Here: rMW72df0586050f: Merge "Update wikimedia/shellbox to 4.1.2"
rMWec80a6a477da: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Jan 2 2025, 12:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2025, 12:15 PM

The backtrace indicates that multiple expired blocks are being purged, so that would need to be included in the reproduction procedure.

		$maxTargetCount = max( $deltasByTarget );
		for ( $delta = 1; $delta <= $maxTargetCount; $delta++ ) {
			$targetsWithThisDelta = array_keys( $deltasByTarget, $delta, true );
			$this->releaseTargets( $dbw, $targetsWithThisDelta, $delta );
		}

$targetsWithThisDelta can be an empty array if $maxTargetCount is greater than one. There is no check for that, and an exception will be thrown.

Change #1108877 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] block: Fix exception when purging multiple expired blocks for the same target

https://gerrit.wikimedia.org/r/1108877

gerritbot added a project: Patch-For-Review.Jan 8 2025, 5:42 AM

I was able to reproduce the exception in a PHPUnit test.

Change #1108877 merged by jenkins-bot:

[mediawiki/core@master] block: Fix exception when purging multiple expired blocks for the same target

https://gerrit.wikimedia.org/r/1108877

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2025, 8:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 8 2025, 9:00 AM

• KSiebert edited projects, added: Community-Tech (Jackal (not a fox) Fox); removed: Community-Tech.Jan 8 2025, 12:22 PM

dom_walden moved this task from Ready for dev to QA on the Community-Tech (Jackal (not a fox) Fox) board.Jan 8 2025, 12:22 PM

dom_walden mentioned this in T378147: Block API: Add support for multiblocks.Jan 9 2025, 2:52 PM

I could not reproduce this bug when I created a lot of blocks against a same user with short expiry times, such that they would be quickly pruned each time I created a new block.

I could reproduce in this way before T382881#10439819 was merged.

On my local environment I have not seen this error in my logs since 7th (the day before the merge).

Test environment: local docker MediaWiki 1.44.0-alpha (72df058) 15:12, 9 January 2025.

tstarling closed this task as Resolved.Jan 9 2025, 10:04 PM

tstarling claimed this task.

InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field bt_idClosed, ResolvedPublicBUG REPORTActions