Page MenuHomePhabricator
Create Task
Maniphest T382888

[breaking change] Remove deprecated icon names
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Remove all icon names marked as // DEPRECATED in icons.ts:

  • cdxIconFullScreen
  • cdxIconNoWikiText
  • cdxIconWikiText

Known usage

ProjectCodeNotes
Extension:MediaSearchextension.json, QuickView.vue

Acceptance criteria

  • Instruct users to update icon names in their code, or open patches for them
  • Merge all patches
  • Remove the deprecated icon names

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Codex from v1.23.0 to 2.0.0-rc.1mediawiki/coremaster+570 -631
[BREAKING CHANGE] icons: remove deprecated iconsdesign/codexmain+3 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Catrope created this task.Jan 2 2025, 2:29 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptJan 2 2025, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope updated the task description. (Show Details)Jan 2 2025, 2:29 PM
CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Jan 6 2025, 9:05 PM
CCiufo-WMF subscribed.

@Catrope is this a Codex 2.0 thing or can we do it now?

Catrope added a project: Codex 2.0.Jan 7 2025, 7:14 PM

Yes, I meant to tag this as such but forgot

Volker_E updated the task description. (Show Details)Jan 7 2025, 7:16 PM
CCiufo-WMF moved this task from Triaging to Backlog on the Design-System-Team board.Jan 7 2025, 7:26 PM
• AnneT updated the task description. (Show Details)Mar 20 2025, 5:38 PM
• AnneT renamed this task from Remove deprecated icon names to [breaking change] Remove deprecated icon names.Mar 20 2025, 9:27 PM
CCiufo-WMF moved this task from Backlog to v2.0.0-rc.1 Release on the Codex 2.0 board.Apr 3 2025, 3:07 PM
• AnneT mentioned this in T391012: Release Codex v2.0.0-rc.1.Apr 3 2025, 5:30 PM
CCiufo-WMF triaged this task as High priority.Apr 14 2025, 5:09 PM
CCiufo-WMF set the point value for this task to 1.
CCiufo-WMF edited projects, added Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)); removed Design-System-Team.Apr 14 2025, 5:11 PM
lwatson changed the status of subtask T390989: MediaSearch: Update deprecated icon name from Open to In Progress.Apr 14 2025, 9:42 PM
lwatson changed the task status from Open to In Progress.Apr 14 2025, 9:49 PM
lwatson claimed this task.
lwatson moved this task from Committed to In Progress on the Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)) board.
gerritbot added a comment.Apr 14 2025, 11:20 PM

Change #1136469 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] [BREAKING CHANGE] icons: remove deprecated icons

https://gerrit.wikimedia.org/r/1136469

gerritbot added a project: Patch-For-Review.Apr 14 2025, 11:20 PM
lwatson closed subtask T390989: MediaSearch: Update deprecated icon name as Resolved.Apr 15 2025, 7:20 PM
• AnneT moved this task from In Progress to Code Review on the Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)) board.Apr 21 2025, 2:57 PM
• AnneT updated the task description. (Show Details)
gerritbot added a comment.Apr 23 2025, 10:48 PM

Change #1136469 merged by jenkins-bot:

[design/codex@main] [BREAKING CHANGE] icons: remove deprecated icons

https://gerrit.wikimedia.org/r/1136469

egardner moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)) board.Apr 23 2025, 10:58 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 23 2025, 11:30 PM
gerritbot added a comment.Apr 29 2025, 9:37 PM

Change #1139942 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v1.23.0 to 2.0.0-rc.1

https://gerrit.wikimedia.org/r/1139942

gerritbot added a project: Patch-For-Review.Apr 29 2025, 9:37 PM
PatchDemoBot added a comment.Apr 29 2025, 9:54 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/f82f2e0c2b/w/

PatchDemoBot added a comment.Apr 30 2025, 1:49 PM

Test wiki created on Patch demo by 1Esk19 using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/ffa0e13429/w/

PatchDemoBot added a comment.Apr 30 2025, 3:23 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/f82f2e0c2b/w/

PatchDemoBot added a comment.May 1 2025, 1:49 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/e49103389b/w/

PatchDemoBot added a comment.May 6 2025, 12:55 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/e49103389b/w/

gerritbot added a comment.May 6 2025, 8:57 PM

Change #1139942 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.23.0 to 2.0.0-rc.1

https://gerrit.wikimedia.org/r/1139942

Maintenance_bot removed a project: Patch-For-Review.May 6 2025, 9:32 PM
• AnneT closed this task as Resolved.May 8 2025, 2:52 PM
PatchDemoBot added a comment.Jun 18 2025, 8:54 PM

Test wiki on Patch demo by 1Esk19 using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/ffa0e13429/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits