What teams or group is this for?
MediaWiki core
Who is your main point of contact and contact preference?
@Krinkle
What are the details of your request? Include relevant timelines or deadlines
In August on T369669 we migrated bare division math to parens-division in Less stylesheet files in web team extensions, but it seems we either missed a few or reintroduced them later.
In T369669#10359330 @Krinkle asks:
Based on the search we originally shared, there appear to still be uses of unparenthesised slash division in MobileFrontend and Minerva. For example:
MobileFrontend - resources/mobile.startup/references/ReferencesDrawer.less
padding: @drawerPadding/2 @drawerPadding @drawerPadding @drawerPadding;
MinervaNeue - minerva.less/minerva.variables.less
@width-search-box: 375/16em;
MinervaNeue - resources/skins.minerva.base.styles/content/toc.less
@toctitle-vertical-padding: 1.4em / 2;
Are these false positives where the code is already compatible with Less.js v5 and its new default of math=parens-division?
How does the request fit withinin the departmental or foundation priorities?
Blocks switching ResourceLoader to math=parens-division (TODO: Phab ticket) and upgrading Less.js 5.0 (T288498)
Is this request urgent or time sensitive?
TBC
Requirement
Review and update any unparenthesized slash divisions in MobileFrontend and MinervaNeue Less stylesheet files to ensure compatibility with Less.js v5 and the math=parens-division requirement. Confirm that there are no regression errors in Pixel reports and that Beta matches Production for the affected features.
Files to Review:
• MobileFrontend: resources/mobile.startup/references/ReferencesDrawer.less
• padding: @drawerPadding/2 @drawerPadding @drawerPadding @drawerPadding;
• MinervaNeue: minerva.less/minerva.variables.less
• @width-search-box: 375/16em;
• MinervaNeue: resources/skins.minerva.base.styles/content/toc.less
• @toctitle-vertical-padding: 1.4em / 2;
BDD
Feature: Ensure Less.js v5 compatibility for MobileFrontend and MinervaNeue
Scenario: Unparenthesized slash divisions are updated
Given a user reviews Less stylesheet files in MobileFrontend and MinervaNeue
When unparenthesized slash divisions are found
Then they should be updated to use parentheses where needed
Scenario: No Pixel errors appear after changes
Given the Less stylesheet changes have been implemented
When test cases for reference drawer, table of contents, and search are executed
Then no errors should be reported in Pixel reports
Scenario: No visual differences between Beta and Production
Given the Less stylesheet changes have been implemented
When the reference drawer, table of contents, and search are compared between Beta and Production
Then there should be no unintended visual differencesTest Steps
Test Case 1: Verify no Pixel errors appear after Less updates
- Navigate to Pixel Reports.
- Review test cases for the following features:
• Reference Drawer
• Table of Contents
• Search
- AC1: Confirm that there are no errors related to Less updates in Pixel reports.
Test Case 2: Verify no visual differences between Beta and Production
- Open Beta and Production versions of the following pages:
• Reference Drawer (e.g., visit a page with references in both environments)
• Table of Contents (e.g., visit an article with multiple sections)
• Search (e.g., open the search bar in both environments)
- Compare the UI elements in both environments.
- Look for any unintended layout shifts, styling inconsistencies, or missing elements.
- AC2: Confirm that there are no unintended visual differences between Beta and Production.
Test case 3: Make sure https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1119720 passes CI
If https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1119720 is passing CI with no issues relating to our code this can be considered a pass.
QA
Confirm Pixel shows no errors relating to this change for test cases for the following features:
- reference drawer
- table of contents
- search
https://pixel.wmcloud.org/reports/mobile/index.html
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T382931#10589715 |
| 2 | ✅ | T382931#10589715 |
| 3 | ✅ | T382931#10619825 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ⬜ | Beta test only |
| 2 | ❌ | T382931#10678244 |
| 3 | ⬜ | Beta test only |
