Page MenuHomePhabricator

Revert RFC url back compatibility
Closed, ResolvedPublic

Description

As part of T71997, the url used for RFC magic links changed recently: 8ca390fe6c4f82e7960a84301101a8391292d727 per https://meta.wikimedia.org/wiki/Talk:Interwiki_map/Archives/2024#RFC

This required patches in Parsoid (https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/1107966 ) to both change the URL used for magic links as well as to ensure backward compatibilty with edit stash contents which still used the older URL.

This task is to manage and eventually remove this back compat code. We don't have a specific policy for edit stash compatibility, but https://www.mediawiki.org/wiki/Manual:Parser_cache/Serialization_compatibility and our general LTS upgrade compatibility suggest that we need to leave the backward compatibility in for a full LTS cycle. (Edit stash contents are populated from the parser cache, so parser cache compatibility requirements imply stash requirements.)

One option is to backport the URL changes (and the back compat code) to the recently-released 1.43 LTS, which would allow the back compatibility code to be removed from production (and 1.44) as soon as the parser cache expires (14 days at the moment, I think) + the edit stash expiration (1 day, I think).

Otherwise we can't remove the back compat code until MW 1.48, the version *after* the next LTS version (1.47) which will have the URL change.

Event Timeline

Change #1107966 had a related patch set uploaded (by C. Scott Ananian; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Sync parserTests with core + update code to pass tests

https://gerrit.wikimedia.org/r/1107966

cscott updated the task description. (Show Details)

Change #1107966 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Sync parserTests with core + update code to pass tests

https://gerrit.wikimedia.org/r/1107966

Sorry for causing such a mess for you - I probably wouldn't have bothered with bypassing the redirect at all if I had known doing it would be so complicated.

cscott added subscribers: MSantos, ssastry, Arlolra.

Assigning to @ssastry for the purposes of CTT workboard, but will require coordination with @Arlolra and @MSantos .

Change #1110838 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a11

https://gerrit.wikimedia.org/r/1110838

Change #1110838 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a11

https://gerrit.wikimedia.org/r/1110838

Change #1153352 had a related patch set uploaded (by Arlolra; author: Pppery):

[mediawiki/core@REL1_43] Update RfC links to bypass redirect

https://gerrit.wikimedia.org/r/1153352

Change #1153352 merged by jenkins-bot:

[mediawiki/core@REL1_43] Update RfC links to bypass redirect

https://gerrit.wikimedia.org/r/1153352

Change #1153368 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_43] Sync up core repo with Parsoid

https://gerrit.wikimedia.org/r/1153368

Change #1153368 merged by jenkins-bot:

[mediawiki/core@REL1_43] Sync up core repo with Parsoid

https://gerrit.wikimedia.org/r/1153368

Change #1153374 had a related patch set uploaded (by Arlolra; author: Subramanya Sastry):

[mediawiki/services/parsoid@REL1_43] Sync parserTests with core + update code to pass tests

https://gerrit.wikimedia.org/r/1153374

Change #1153374 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] Sync parserTests with core + update code to pass tests

https://gerrit.wikimedia.org/r/1153374

Change #1153409 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@REL1_43] Update wikimedia/parsoid to 0.20.3

https://gerrit.wikimedia.org/r/1153409

Change #1153410 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_43] Update wikimedia/parsoid to 0.20.3

https://gerrit.wikimedia.org/r/1153410

Change #1153409 merged by Arlolra:

[mediawiki/vendor@REL1_43] Update wikimedia/parsoid to 0.20.3

https://gerrit.wikimedia.org/r/1153409

Change #1153414 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove b/c for RFC magic link url

https://gerrit.wikimedia.org/r/1153414

Change #1153410 merged by jenkins-bot:

[mediawiki/core@REL1_43] Update wikimedia/parsoid to 0.20.3

https://gerrit.wikimedia.org/r/1153410

Change #1153414 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove b/c for RFC magic link url

https://gerrit.wikimedia.org/r/1153414

Change #1154863 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a6

https://gerrit.wikimedia.org/r/1154863

Change #1154863 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a6

https://gerrit.wikimedia.org/r/1154863