Page MenuHomePhabricator
Create Task
Maniphest T382987

Set the default of wgDnsBlacklistUrls to empty
Closed, ResolvedPublic
Actions

Description

The current default value of $wgDnsBlacklistUrls is [ 'http.dnsbl.sorbs.net.', ].

However, according to sorbs.net, they have terminated the service and all queries will return NXDOMAIN. Having such a default value is now meaningless, and does not block any spams. Replacing it with empty can avoid some users still using sorbs.net continue querying SORBS.

Note that this default value is also used on some WMF wikis:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Disable Dns Blacklist checksoperations/mediawiki-configmaster+1 -16
DnsBlacklistUrls: Remove sorbs.netmediawiki/coreREL1_43+24 -4
DnsBlacklistUrls: Remove sorbs.netmediawiki/coreREL1_42+16 -4
DnsBlacklistUrls: Remove sorbs.netmediawiki/coreREL1_39+16 -4
DnsBlacklistUrls: Remove sorbs.netmediawiki/coremaster+9 -4
Customize query in gerrit

Related Objects

Event Timeline

XtexChooser created this task.Jan 4 2025, 1:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 4 2025, 1:12 PM
XtexChooser updated the task description. (Show Details)Jan 4 2025, 1:42 PM
Peachey88 added a project: MediaWiki-General.Jan 4 2025, 1:49 PM
Peachey88 updated the task description. (Show Details)
Bugreporter subscribed.Jan 4 2025, 2:07 PM

Note there is also proposal to deprecate and remove this setting completely, see T76301: Remove all proxy blocking functionalities from mediawiki core

A_smart_kitten added a project: MediaWiki-Blocks.Jan 4 2025, 2:30 PM
A_smart_kitten subscribed.
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptJan 4 2025, 2:30 PM
A_smart_kitten added a comment.Jan 4 2025, 2:34 PM

(noting that I didn't see the MediaWiki-General tag when I tagged with MediaWiki-Blocks -- this config variable seems to be part of core block functionality per BlockManager.php#L642; however, feel free to remove the tag if it is incorrect here)

Pppery removed a project: MediaWiki-General.Jan 4 2025, 3:10 PM
Reedy added projects: MW-1.39-release, MW-1.42-release, MW-1.43-release.Jan 4 2025, 11:41 PM
gerritbot added a comment.Jan 4 2025, 11:49 PM

Change #1108179 had a related patch set uploaded (by Reedy; author: Reedy):

[operations/mediawiki-config@master] Disable Dns Blacklist checks

https://gerrit.wikimedia.org/r/1108179

gerritbot added a project: Patch-For-Review.Jan 4 2025, 11:49 PM
gerritbot added a comment.Jan 4 2025, 11:52 PM

Change #1108180 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108180

Reedy added a project: Wikimedia-Site-requests.Jan 4 2025, 11:54 PM
Reedy triaged this task as Low priority.Jan 4 2025, 11:56 PM
gerritbot added a comment.Jan 6 2025, 10:32 PM

Change #1108180 merged by jenkins-bot:

[mediawiki/core@master] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108180

gerritbot added a comment.Jan 6 2025, 10:34 PM

Change #1108498 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108498

gerritbot added a comment.Jan 6 2025, 10:34 PM

Change #1108499 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_42] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108499

gerritbot added a comment.Jan 6 2025, 10:35 PM

Change #1108500 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108500

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.12; 2025-01-14).Jan 6 2025, 11:00 PM
gerritbot added a comment.Jan 6 2025, 11:20 PM

Change #1108500 merged by jenkins-bot:

[mediawiki/core@REL1_39] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108500

gerritbot added a comment.Jan 6 2025, 11:21 PM

Change #1108499 merged by jenkins-bot:

[mediawiki/core@REL1_42] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108499

gerritbot added a comment.Jan 6 2025, 11:26 PM

Change #1108498 merged by jenkins-bot:

[mediawiki/core@REL1_43] DnsBlacklistUrls: Remove sorbs.net

https://gerrit.wikimedia.org/r/1108498

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.43-notes, MW-1.42-notes.Jan 7 2025, 12:01 AM
Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.39-release board.Jan 10 2025, 2:52 PM
Jdforrester-WMF moved this task from Blocker to Not a blocker on the MW-1.43-release board.
gerritbot added a comment.Jan 28 2025, 8:36 AM

Change #1108179 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable Dns Blacklist checks

https://gerrit.wikimedia.org/r/1108179

Stashbot added a comment.Jan 28 2025, 8:43 AM

Mentioned in SAL (#wikimedia-operations) [2025-01-28T08:43:29Z] <reedy@deploy2002> Started scap sync-world: Backport for [[gerrit:1110053|CommonSettings: Set 'lang=en' on Wikimedia Foundation entry in $wgFooterIcons (T383501)]], [[gerrit:1114454|SimpleCaptcha: Don't look up captcha if no ID was given (T384858)]], [[gerrit:1091818|noc: Expose MobileUrlCallback.php]], [[gerrit:1108179|Disable Dns Blacklist checks (T382987)]], [[gerrit:1088655|CommonSettings.php: Remove deprecated $wg

Stashbot mentioned this in T384858: PHP Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated.Jan 28 2025, 8:43 AM
Stashbot mentioned this in T383501: Add language to footer icons.
Stashbot added a comment.Jan 28 2025, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2025-01-28T08:48:17Z] <reedy@deploy2002> reedy, jforrester: Backport for [[gerrit:1110053|CommonSettings: Set 'lang=en' on Wikimedia Foundation entry in $wgFooterIcons (T383501)]], [[gerrit:1114454|SimpleCaptcha: Don't look up captcha if no ID was given (T384858)]], [[gerrit:1091818|noc: Expose MobileUrlCallback.php]], [[gerrit:1108179|Disable Dns Blacklist checks (T382987)]], [[gerrit:1088655|CommonSettings.php: Remove deprecated $wgOATHAu

Reedy moved this task from Blocker to Not a blocker on the MW-1.42-release board.Jan 28 2025, 8:51 AM
Stashbot added a comment.Jan 28 2025, 8:56 AM

Mentioned in SAL (#wikimedia-operations) [2025-01-28T08:56:27Z] <reedy@deploy2002> Finished scap sync-world: Backport for [[gerrit:1110053|CommonSettings: Set 'lang=en' on Wikimedia Foundation entry in $wgFooterIcons (T383501)]], [[gerrit:1114454|SimpleCaptcha: Don't look up captcha if no ID was given (T384858)]], [[gerrit:1091818|noc: Expose MobileUrlCallback.php]], [[gerrit:1108179|Disable Dns Blacklist checks (T382987)]], [[gerrit:1088655|CommonSettings.php: Remove deprecated $w

Reedy closed this task as Resolved.Jan 28 2025, 8:56 AM
Reedy claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits