Page MenuHomePhabricator
Create Task
Maniphest T383

RfC: Data mapper
Closed, DeclinedPublic
Actions

Description

This RFC proposes adding a data mapper facility to core. Hopefully, this will promote domain-driven design and help isolate database access. It seems compatible with the recently approved move to a service-oriented architecture. An implementation with tests and examples is provided.

Implemented and merged on a WIP branch of the Campaigns extension for the Editor campaigns project

Details: https://www.mediawiki.org/wiki/Requests_for_comment/Data_mapper
Has overlap and should be coordinated with: https://www.mediawiki.org/wiki/Requests_for_comment/SQL_framework

Details

Reference
fl576

Related Objects

Event Timeline

• flimport raised the priority of this task from to High.Sep 12 2014, 1:47 AM
• flimport added a project: Architecture.
• flimport set Reference to fl576.

qgil wrote on 2014-09-03 06:03:56 (UTC)

This RFC has been scheduled to be discussed in the Architecture RfC meeting on 2014-09-10.

Qgil edited projects, added TechCom-RFC; removed Architecture.Oct 22 2014, 8:45 PM
tstarling added a project: TechCom.Nov 20 2014, 5:52 AM
tstarling set Security to None.
JanZerebecki subscribed.Feb 5 2015, 1:26 PM
daniel updated the task description. (Show Details)Feb 27 2015, 3:41 PM
daniel changed the task status from Open to Stalled.Feb 27 2015, 3:48 PM
daniel subscribed.

Apparently, this was scheduled but never discussed, probably due to Andrew's mail here http://www.gossamer-threads.com/lists/wiki/wikitech/503509

The RfC on using Composer-manager libraries [1] is definitely a
potential game-changer here. BTW, the data mapper and dependency
injection RfCs and the implementations were created before that was
accepted. I still hope that they can be spaces for talking about
possible change in these areas, and that the implementations at least
serve to scope out possible directions. Cheers,
Andrew
daniel moved this task from P1: Define to Old on the TechCom-RFC board.Feb 27 2015, 3:48 PM
• Spage removed a project: TechCom.May 15 2015, 1:03 AM
• Spage assigned this task to • AndyRussG.May 15 2015, 1:37 AM
• Spage subscribed.
In T383#1073604, @daniel wrote:

Apparently, this was scheduled but never discussed

It was discussed on 2014-09-10, see summary; conclusion was "ACTION: AndyRussG to write a more generic ORM RFC comparing implementation options"

Andrew, any update?

• AndyRussG added a comment.May 25 2015, 9:35 PM

Hi @Spage and @daniel... I haven't had time to move foreward with this, but I'd sure love to! If there were a set calendar for doing so, that would help me integrate it with other tasks... what do you think? Also, any more help on this would be fantastic, of course. Apologies for the delay in responding ;p Thanks!!!

Danny_B added a project: Proposal.May 2 2016, 10:30 PM
• RobLa-WMF subscribed.May 10 2016, 10:50 PM

@AndyRussG - is this still an RFC you're interested in? @daniel, how about you?

The priority is currently set to "High", which seems like a mismatch given the level of activity on this and lack of discussion on wikitech-l. We should lower this to "Low" priority in our next triage discussion (barring persuasive comment here)

JanZerebecki updated the task description. (Show Details)May 11 2016, 6:33 PM
JanZerebecki added a comment.May 11 2016, 8:39 PM

Nobody working on this for Mediawiki would be a mistake. The evidence for that are multiple existing implementations of something like this deployed in production that are not reusable. Also some extensions use doctrine.
@AndyRussG Who do we need to convince, so you have time?
Are there other people interested on working on this?

• RobLa-WMF added a comment.May 12 2016, 1:34 AM
In T383#2286762, @JanZerebecki wrote:

Nobody working on this for Mediawiki would be a mistake. The evidence for that are multiple existing implementations of something like this deployed in production that are not reusable. Also some extensions use doctrine.

@JanZerebecki - can you make that case on wikitech-l?

• RobLa-WMF mentioned this in E187: RFC Meeting: triage meeting (2016-05-25, #wikimedia-office).May 25 2016, 7:03 AM
Krinkle removed a project: Proposal.Dec 21 2017, 11:39 PM
• kchapman moved this task from Old to Declined on the TechCom-RFC board.Mar 8 2018, 10:36 PM
• kchapman subscribed.

@AndyRussG TechCom is closing this, but feel free to reopen with an updated version if you want it reviewed again.

Krinkle closed this task as Declined.Mar 14 2018, 8:14 PM
Krinkle subscribed.

(Closing the overall task, given there are no other projects associated with this task.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits