Page MenuHomePhabricator
Create Task
Maniphest T383065

Wikifunction's Gerrit runs end-to-end tests run against a Catalyst environment
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

This is a "white glove" kind of story where we aim to get wikilambda CI working with Catalyst. The goal is to:

  1. set up e2e CI with catalyst for wikilambda on gerrit
  2. learn the steps to set this up
  3. make a write-up of the steps in this task for us to write formal documentation later

AS an Abstract Wikipedia engineer
WHEN I push a new wikilambda patch to Gerrit
THEN I see that a Catalyst environment is being provisioned

AS an Abstract Wikipedia engineer
WHEN I wait for the end-to-end test to finish
AND the end-to-end tests finish
THEN I see whether the tests passed or failed
AND I see a link to the environment

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikilambda-catalyst e2e: Use new docker imageintegration/configmaster+5 -1
dockerfiles/catalyst: Configurable MW env varsintegration/configmaster+6 -3
catalyst: add https to MW_SERVER URLintegration/configmaster+7 -1
dockerfiles/catalyst: make npm args variableintegration/configmaster+8 -2
Catalyst: Make npm args to catalyst variableintegration/configmaster+10 -3
Remove wikilambda e2e test parameterintegration/configmaster+1 -6
Update wikilambda e2e test parametersintegration/configmaster+1 -4
Add wikilamba end-to-end selenium testingintegration/configmaster+47 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

SDunlap created this task.Jan 6 2025, 4:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2025, 4:25 PM
thcipriani subscribed.Jan 6 2025, 5:45 PM

This would involve adding a step to the test pipeline in zuul/layout.yaml. And defining a test to run somewhere in JJB within that same repo.

We can start by defining a docker image that makes the Catalyst calls we need. This will eventually live in integration/config's dockerfile directory but it should inherit from one of our CI-base images; e.g. ci-bookworm.

Secrets for jobs are stored within Jenkins itself and there are several patterns for getting those secrets into jobs. In general, environment variables work.

thcipriani assigned this task to Mhurd.Jan 6 2025, 5:50 PM
thcipriani edited projects, added Catalyst (Fork around 🍴); removed Catalyst.
thcipriani set the point value for this task to 5.
thcipriani moved this task from Backlog to Ready on the Catalyst (Fork around 🍴) board.
vaughnwalters subscribed.Jan 7 2025, 4:38 AM
thcipriani edited projects, added Catalyst (Secure Spa); removed Catalyst (Fork around 🍴).Jan 13 2025, 5:19 PM
thcipriani moved this task from Backlog to Ready on the Catalyst (Secure Spa) board.Jan 13 2025, 5:35 PM
Mhurd added a comment.Jan 23 2025, 10:31 PM

WIP:

https://gitlab.wikimedia.org/mhurd/t383065

Mhurd added a comment.EditedJan 23 2025, 10:39 PM

So far, the WIP has these working scripts:

create
Instructs environments endpoint to create a mediawiki/wikilambda instance

list
Shows instances created with the specified token (token lives in ./env)

remove
Passed the id of an instance to remove (can get the instance from list output)

wait
Pops open a browser window (using open on macOS host) once the instance is serving up pages

—

Implemented these to ensure I could bring things up/down

Next step is wiring up the Dockerfile

thcipriani added a comment.Jan 27 2025, 7:57 PM

Sweet.

We want to run selenium tests against the environment: example of how it runs.

To do this, follow the example in the integration/config repo: node22-test-browser.

Our pattern for running docker images in Jenkins is you'll get a few directories mounted to your container:

  • /src -- The source code for the WikiLambda extension.
  • /log -- An empty directory that will be saved as artifacts.
  • /cache -- A directory that may be re-used from run to run to speed up builds by preserving dependencies/cache directories.
Mhurd added a comment.Jan 27 2025, 7:58 PM

Perfect thanks!! Will jump back on this post-sprinthackular

thcipriani edited projects, added Catalyst (Kiwen); removed Catalyst (Secure Spa).Jan 31 2025, 8:10 PM
thcipriani moved this task from Backlog to In progress on the Catalyst (Kiwen) board.Jan 31 2025, 8:13 PM
zeljkofilipin subscribed.Feb 4 2025, 5:41 PM
Mhurd removed Mhurd as the assignee of this task.EditedFeb 18 2025, 5:33 PM
Mhurd subscribed.

I would still love to work on this, but we've had so many Pixel fires to put out lately (most of last week, now again today) that I have to focus on getting it back up since other teams depend on it

thcipriani edited projects, added Catalyst (ilopona); removed Catalyst (Kiwen).Feb 24 2025, 5:23 PM
thcipriani assigned this task to jeena.Feb 28 2025, 8:06 PM
thcipriani moved this task from Backlog to Ready on the Catalyst (ilopona) board.
thcipriani added a parent task: T388056: Run Wikilambda daily selenium tests against Catalyst.Mar 6 2025, 10:29 PM
thcipriani mentioned this in T388056: Run Wikilambda daily selenium tests against Catalyst.Mar 6 2025, 10:32 PM
Jdforrester-WMF subscribed.Mar 6 2025, 10:45 PM
thcipriani moved this task from Ready to In progress on the Catalyst (ilopona) board.Mar 7 2025, 8:11 PM
thcipriani edited projects, added Catalyst (ko); removed Catalyst (ilopona).Mar 17 2025, 4:31 PM
thcipriani moved this task from Backlog to In progress on the Catalyst (ko) board.
gerritbot added a comment.Mar 24 2025, 9:07 PM

Change #1130722 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] WIP: Add wikilamba end-to-end selenium testing

https://gerrit.wikimedia.org/r/1130722

gerritbot added a project: Patch-For-Review.Mar 24 2025, 9:08 PM
gerritbot added a comment.Mar 25 2025, 9:05 PM

Change #1130722 merged by jenkins-bot:

[integration/config@master] Add wikilamba end-to-end selenium testing

https://gerrit.wikimedia.org/r/1130722

gerritbot added a comment.Mar 25 2025, 9:19 PM

Change #1131097 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] Update wikilambda e2e test parameters

https://gerrit.wikimedia.org/r/1131097

jeena moved this task from In progress to Waiting for review on the Catalyst (ko) board.Mar 25 2025, 9:38 PM
gerritbot added a comment.Mar 25 2025, 10:01 PM

Change #1131097 merged by jenkins-bot:

[integration/config@master] Update wikilambda e2e test parameters

https://gerrit.wikimedia.org/r/1131097

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 10:30 PM
gerritbot added a comment.Mar 26 2025, 2:51 AM

Change #1131121 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] Remove wikilambda e2e test parameter

https://gerrit.wikimedia.org/r/1131121

gerritbot added a project: Patch-For-Review.Mar 26 2025, 2:51 AM
gerritbot added a comment.Mar 26 2025, 2:56 AM

Change #1131121 merged by jenkins-bot:

[integration/config@master] Remove wikilambda e2e test parameter

https://gerrit.wikimedia.org/r/1131121

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 3:30 AM
thcipriani closed this task as Resolved.Mar 31 2025, 4:15 PM

@vaughnwalters we're closing out the initial work to get this stood up in Gerrit, but if you have followups (i.e., something not working like it should) let us know and we can add new tasks to our backlog.

gerritbot added a comment.Apr 8 2025, 8:25 PM

Change #1135094 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] Catalyst: Make npm args to catalyst variable

https://gerrit.wikimedia.org/r/1135094

gerritbot added a project: Patch-For-Review.Apr 8 2025, 8:25 PM
gerritbot added a comment.Apr 8 2025, 8:35 PM

Change #1135098 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] dockerfiles/catalyst: make npm args variable

https://gerrit.wikimedia.org/r/1135098

gerritbot added a comment.Apr 8 2025, 8:35 PM

Change #1135094 abandoned by Jeena Huneidi:

[integration/config@master] Catalyst: Make npm args to catalyst variable

Reason:

splitting docker and jjb changes

https://gerrit.wikimedia.org/r/1135094

gerritbot added a comment.Apr 8 2025, 8:39 PM

Change #1135099 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] wikilambda-catalyst e2e: Use new docker image

https://gerrit.wikimedia.org/r/1135099

gerritbot added a comment.Apr 8 2025, 8:43 PM

Change #1135098 merged by jenkins-bot:

[integration/config@master] dockerfiles/catalyst: make npm args variable

https://gerrit.wikimedia.org/r/1135098

gerritbot added a comment.Apr 8 2025, 9:49 PM

Change #1135123 had a related patch set uploaded (by Brennen Bearnes; author: Brennen Bearnes):

[integration/config@master] catalyst: add https to MW_SERVER URL

https://gerrit.wikimedia.org/r/1135123

gerritbot added a comment.Apr 8 2025, 10:01 PM

Change #1135123 merged by jenkins-bot:

[integration/config@master] catalyst: add https to MW_SERVER URL

https://gerrit.wikimedia.org/r/1135123

Stashbot added a comment.Apr 8 2025, 10:02 PM

Mentioned in SAL (#wikimedia-releng) [2025-04-08T22:02:53Z] <brennen> Updating docker-pkg files on contint primary for T383065

gerritbot added a comment.Apr 8 2025, 10:22 PM

Change #1135128 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[integration/config@master] dockerfiles/catalyst: Configurable MW env vars

https://gerrit.wikimedia.org/r/1135128

gerritbot added a comment.Apr 8 2025, 10:36 PM

Change #1135128 merged by jenkins-bot:

[integration/config@master] dockerfiles/catalyst: Configurable MW env vars

https://gerrit.wikimedia.org/r/1135128

gerritbot added a comment.Apr 8 2025, 10:51 PM

Change #1135099 merged by jenkins-bot:

[integration/config@master] wikilambda-catalyst e2e: Use new docker image

https://gerrit.wikimedia.org/r/1135099

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2025, 11:30 PM
thcipriani added projects: Release-Engineering-Team (Radar), OKR-Work.Apr 10 2025, 2:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits