Page MenuHomePhabricator
Create Task
Maniphest T383141

Replace cite-tracking-category-cite-diffing-error category by an entry in the ParserLimit report
Closed, ResolvedPublic
Actions

Description

After consideration and discussion, suppressing errors in visual-diff based on categories is a bad idea - mostly because said categories can be suppressed by wikis, for whom it is actually not useful.
For this task, we remove cite-tracking-category-cite-diffing-error (but leave the localization messages for the time being for cache reasons), and replace it by an entry in the ParserLimit report.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove cite-diffing-error tracking categorymediawiki/extensions/Citemaster+0 -5
Remove cite-tracking-category-cite-diffing-errormediawiki/extensions/Citemaster+2 -36
Customize query in gerrit

Related Objects
Search...

Event Timeline

ihurbain created this task.Jan 7 2025, 5:28 PM
Restricted Application edited projects, added: Parsoid; removed: Patch-For-Review. · View Herald TranscriptJan 7 2025, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ihurbain moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Jan 7 2025, 5:29 PM
gerritbot added a comment.Jan 7 2025, 6:13 PM

Change #1108804 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Cite@master] Replace cite-tracking-category-cite-diffing-error by LimitReport entry

https://gerrit.wikimedia.org/r/1108804

gerritbot added a project: Patch-For-Review.Jan 7 2025, 6:13 PM
MSantos removed a project: Parsoid.Jan 16 2025, 3:19 PM
MSantos added a project: Cite.
ABreault-WMF subscribed.Jan 17 2025, 6:14 PM

We keep the entries in the localization file for now until the parser cache has had a chance to expire existing entries.

Probably shouldn't close out this task until we go back and remove that in a few weeks.

gerritbot added a comment.Jan 17 2025, 7:03 PM

Change #1108804 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove cite-tracking-category-cite-diffing-error

https://gerrit.wikimedia.org/r/1108804

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 17 2025, 8:00 PM
ihurbain moved this task from In Progress to Blocked on the Content-Transform-Team-WIP board.Jan 27 2025, 3:21 PM

Moved to "Block" - will unblock in a few weeks by virtue of caches expiring.

ihurbain added a project: Content-Transform-Team (Work In Progress).Feb 6 2025, 3:40 PM
ihurbain moved this task from Backlog to Blocked on the Content-Transform-Team (Work In Progress) board.
ihurbain removed a project: Content-Transform-Team-WIP.Feb 7 2025, 2:33 PM
MSantos edited projects, added: Parsoid-Read-Views (Incubator Wiki Q3 FY2024-25); removed: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21), Parsoid-Read-Views (Phase 1 - DiscussionTools support).Mar 13 2025, 12:36 PM
ihurbain moved this task from Blocked to In Progress on the Content-Transform-Team (Work In Progress) board.Apr 14 2025, 3:17 PM
ihurbain removed ihurbain as the assignee of this task.Jul 1 2025, 3:04 PM
ihurbain moved this task from In Progress to Backlog on the Content-Transform-Team (Work In Progress) board.
MSantos moved this task from Incubator Wiki Q3 FY2024-25 to Small Size Wikipedias on the Parsoid-Read-Views board.Sep 25 2025, 2:36 PM
MSantos edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views (Incubator Wiki Q3 FY2024-25).
MSantos assigned this task to ihurbain.Oct 16 2025, 2:24 PM
MSantos moved this task from Backlog to Needs Investigation on the Content-Transform-Team (Work In Progress) board.
MSantos removed a project: Content-Transform-Team (Work In Progress).
MSantos edited projects, added: Parsoid-Read-Views; removed: Parsoid-Read-Views (Small Size Wikipedias).
MSantos moved this task from Uncategorized to Non-blockers (any wiki) on the Parsoid-Read-Views board.Nov 13 2025, 3:42 PM
gerritbot added a comment.Mar 6 2026, 3:27 PM

Change #1248860 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/extensions/Cite@master] Remove cite-diffing-error tracking category

https://gerrit.wikimedia.org/r/1248860

gerritbot added a comment.Mar 9 2026, 9:40 AM

Change #1248860 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove cite-diffing-error tracking category

https://gerrit.wikimedia.org/r/1248860

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.19; 2026-03-10).Mar 9 2026, 10:00 AM
ihurbain added a project: Content-Transform-Team (Work In Progress).Mar 9 2026, 3:11 PM
ihurbain moved this task from Needs Investigation to To Deploy on the Content-Transform-Team (Work In Progress) board.
ihurbain closed this task as Resolved.Apr 13 2026, 3:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits