Page MenuHomePhabricator
Create Task
Maniphest T383157

[25Q3] Improve performance and drive down tech debt & developer inhibitors
Closed, ResolvedPublic
Actions

Description

Background
Engineering collaboration to identify priority tech debt fixes for this quarter.

Backend:

  • testing: debugging and monitoring JS performance
  • Orchestrator: reducing process time for large (Wikidata) objects

Frontend:

  • Vue performance: reducing page-load time on (large) objects

Approach

  1. Find out where/why the delays are occurring
  2. Devise and create way(s) to gain clarity; debugging
  3. Plan and create tasks to solve issue from found data

Acceptance Criteria/Success Metrics

  • Performance requirements for Wikidata and Wikipedia integrations are met

Success:

  • Completion of Wikidata work because of performance improvement

Stretch Goal

  • [Frontend] Performance cont - PHP performance
  • [Backend + Frontend] Re-enabling disabled features
  • [Backend] Splitting out built-in code from Orchestrator into Evaluator
  • [Frontend] Show error messages from the PHP layer (e.g. Orchestrator missing) in the front end, rather than ugly "HTTP –"

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
wikifunctions: Upgrade orchestrator from 2025-01-22-203140 to 2025-01-28-144249operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249operations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Dependency-inject expensive functions and tests to count the number of times that they are calledrepos/abstract-wiki/wikifunctions/function-orchestrator!272apineapine-count-callsmain
Customize query in GitLab

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedecargT383157 [25Q3] Improve performance and drive down tech debt & developer inhibitors
 ResolvedBUG REPORTgenghT378169 Review front-end performance of convertTableToJson usage
 ResolvedecargT379432 Create a way to temporarily bypass the results cache on production
 ResolvedgenghT375065 [25Q2] Improve performance of the PHP layer
 ResolvedecargT382111 [documentation] how to analyze traces and logs to understand production issues
 ResolvedecargT382110 [documentation] add debugging in Prod tips: toggling lower log levels live
 ResolvedecargT383740 [spike] find out what type of requests might trigger NodeJS heap/memory errors
 ResolvedcmassaroT383806 [spike] find out where the delay is coming from
ResolvedcmassaroT388683 Fetching of JSON objects from the Wikifunctions and Wikidata APIs takes longer from the orchestrator in k8s than from the deployment host
 ResolvedcmassaroT380103 Deduplicate Fetching Logic in src/db.js
 ResolvedecargT383808 [documentation] AW architecture
 ResolvedcmassaroT379977 Skip idempotent operations in the orchestrator, for performance
 ResolvedcmassaroT383573 Consider Returning `ZWrapper`s from builtin functions
 ResolvedcmassaroT379978 Skip final resolution of instances of Wikidata types
 ResolvedcmassaroT382015 Incrementally validate objects in the orchestrator; avoid duplicate validation
 ResolvedecargT385859 increase CPU and Node heap limit?
 ResolvedDSmit-WMFT386188 Replace anonymous functions returned by Pinia getters with named functions to help with profiling
 ResolvedecargT388298 handle null cases for Scope
 ResolvedecargT388174 adjust frequency of alerts
 ResolvedecargT386433 create a unit test to count recursive calls for builtin zobjects
 ResolvedecargT388932 orchestrator duration metrics is not working?
 ResolvedcmassaroT383575 Consider using compareTypes in builtin type checking functions
 ResolvedecargT388859 adjust execution duration metric

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• Sharvaniharan triaged this task as Medium priority.Jan 7 2025, 7:39 PM
• Sharvaniharan renamed this task from [25Q3] Tech debt and Developer experience improvements to [25Q3] Improve performance and drive down tech debt & developer inhibitors.Jan 9 2025, 7:08 PM
• Sharvaniharan added a project: Epic.
Jdforrester-WMF added a subtask: T378169: Review front-end performance of convertTableToJson usage.Jan 14 2025, 4:46 PM
ecarg updated the task description. (Show Details)Jan 14 2025, 5:02 PM
ecarg added a subtask: T379432: Create a way to temporarily bypass the results cache on production.Jan 14 2025, 9:22 PM
ecarg added a subtask: T375065: [25Q2] Improve performance of the PHP layer.Jan 14 2025, 9:25 PM
ecarg added a subtask: T382111: [documentation] how to analyze traces and logs to understand production issues.Jan 14 2025, 9:38 PM
ecarg added a subtask: T382110: [documentation] add debugging in Prod tips: toggling lower log levels live.
ecarg added a subtask: T383740: [spike] find out what type of requests might trigger NodeJS heap/memory errors.Jan 14 2025, 9:50 PM
ecarg added a subtask: T383806: [spike] find out where the delay is coming from .Jan 15 2025, 5:48 PM
ecarg added a subtask: T380103: Deduplicate Fetching Logic in src/db.js.Jan 15 2025, 6:02 PM
ecarg updated the task description. (Show Details)Jan 15 2025, 6:05 PM
ecarg added a subtask: T383808: [documentation] AW architecture.Jan 15 2025, 8:43 PM
ecarg added a subtask: T378782: [spike] install-rust && wasmedge build inconsistent and fails depending on env.Jan 16 2025, 5:02 AM
ecarg added a subtask: T378690: Metadata Dialog: Build a detailed error view.
ecarg added a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.Jan 16 2025, 5:29 AM
Jdforrester-WMF closed subtask T380103: Deduplicate Fetching Logic in src/db.js as Resolved.Jan 21 2025, 2:37 PM
CodeReviewBot added a project: Patch-For-Review.Jan 21 2025, 6:13 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/272

Dependency-inject expensive functions and tests to count the number of times that they are called

Jdforrester-WMF removed a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.Jan 22 2025, 5:36 PM
Jdforrester-WMF added a subtask: T368892: Enabling the nestedMetadata functionality on Wikifunctions.org causes evaluations to often fail with "gateway timeout" or “service unavailable”.
ecarg added a subtask: T384521: [spike] decide on splitting out built-in code from Orchestrator into Evaluator.Jan 22 2025, 6:13 PM
cmassaro added a subtask: T379977: Skip idempotent operations in the orchestrator, for performance.Jan 23 2025, 2:16 PM
cmassaro changed the status of subtask T379977: Skip idempotent operations in the orchestrator, for performance from Open to In Progress.
CodeReviewBot added a comment.Jan 23 2025, 9:11 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/272

Dependency-inject expensive functions and tests to count the number of times that they are called

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2025, 9:30 PM
ecarg added a subtask: T383573: Consider Returning `ZWrapper`s from builtin functions.Jan 23 2025, 10:24 PM
ecarg changed the status of subtask T382111: [documentation] how to analyze traces and logs to understand production issues from Open to In Progress.Jan 27 2025, 9:03 PM
ecarg changed the status of subtask T379432: Create a way to temporarily bypass the results cache on production from Open to In Progress.Jan 27 2025, 9:07 PM
gerritbot added a comment.Jan 29 2025, 2:28 PM

Change #1115028 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115028

gerritbot added a project: Patch-For-Review.Jan 29 2025, 2:28 PM
gerritbot added a comment.Jan 29 2025, 2:34 PM

Change #1115032 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115032

gerritbot added a comment.Jan 29 2025, 2:36 PM

Change #1115032 abandoned by Cory Massaro:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from version: 2025-01-22-203140 to 2025-01-28-144249

Reason:

already done

https://gerrit.wikimedia.org/r/1115032

gerritbot added a comment.Jan 29 2025, 3:05 PM

Change #1115028 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-01-22-203140 to 2025-01-28-144249

https://gerrit.wikimedia.org/r/1115028

DSantamaria closed subtask T379977: Skip idempotent operations in the orchestrator, for performance as Resolved.Jan 31 2025, 12:36 PM
DSantamaria changed the status of subtask T383740: [spike] find out what type of requests might trigger NodeJS heap/memory errors from Open to In Progress.Jan 31 2025, 12:46 PM
DSantamaria changed the status of subtask T383573: Consider Returning `ZWrapper`s from builtin functions from Open to In Progress.Jan 31 2025, 12:51 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2025, 1:31 PM
DSantamaria removed a subtask: T378690: Metadata Dialog: Build a detailed error view.Jan 31 2025, 3:48 PM
cmassaro reopened subtask T379977: Skip idempotent operations in the orchestrator, for performance as Open.Feb 3 2025, 12:22 PM
ecarg changed the status of subtask T383806: [spike] find out where the delay is coming from from Open to In Progress.Feb 5 2025, 3:52 PM
DSantamaria added a subtask: T381597: Consider removing/replacing JSON schemata validators.Feb 5 2025, 5:33 PM
Jdforrester-WMF added a subtask: T379978: Skip final resolution of instances of Wikidata types.Feb 5 2025, 5:57 PM
Jdforrester-WMF added a subtask: T382015: Incrementally validate objects in the orchestrator; avoid duplicate validation.
ecarg closed subtask T383740: [spike] find out what type of requests might trigger NodeJS heap/memory errors as Resolved.Feb 5 2025, 9:10 PM
ecarg closed subtask T382111: [documentation] how to analyze traces and logs to understand production issues as Resolved.Feb 6 2025, 7:29 AM
DSantamaria changed the status of subtask T381597: Consider removing/replacing JSON schemata validators from Open to In Progress.Feb 6 2025, 12:11 PM
ecarg changed the status of subtask T383808: [documentation] AW architecture from Open to In Progress.Feb 6 2025, 4:02 PM
ecarg changed the status of subtask T382110: [documentation] add debugging in Prod tips: toggling lower log levels live from Open to In Progress.Feb 6 2025, 9:46 PM
ecarg closed subtask T382110: [documentation] add debugging in Prod tips: toggling lower log levels live as Resolved.Feb 7 2025, 4:22 AM
ecarg added a subtask: T385859: increase CPU and Node heap limit?.Feb 7 2025, 7:36 AM
ecarg closed subtask T382015: Incrementally validate objects in the orchestrator; avoid duplicate validation as Resolved.Feb 7 2025, 9:27 PM
ecarg changed the status of subtask T384521: [spike] decide on splitting out built-in code from Orchestrator into Evaluator from Open to Stalled.Feb 11 2025, 3:55 AM
Jdforrester-WMF closed subtask T379978: Skip final resolution of instances of Wikidata types as Resolved.Feb 11 2025, 1:00 PM
gengh added a subtask: T386188: Replace anonymous functions returned by Pinia getters with named functions to help with profiling.Feb 12 2025, 11:41 AM
Jdforrester-WMF closed subtask T383573: Consider Returning `ZWrapper`s from builtin functions as Resolved.Feb 13 2025, 5:45 PM
DSantamaria added a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.Feb 21 2025, 6:09 AM
DSantamaria changed the status of subtask T379977: Skip idempotent operations in the orchestrator, for performance from Open to In Progress.Feb 26 2025, 6:20 AM
DSmit-WMF changed the status of subtask T386188: Replace anonymous functions returned by Pinia getters with named functions to help with profiling from Open to In Progress.Feb 26 2025, 1:39 PM
Jdforrester-WMF closed subtask T379432: Create a way to temporarily bypass the results cache on production as Resolved.Feb 27 2025, 2:38 PM
DSantamaria removed a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.Mar 3 2025, 2:28 PM
gengh changed the status of subtask T378169: Review front-end performance of convertTableToJson usage from Open to In Progress.Mar 4 2025, 2:54 PM
ecarg closed subtask T383808: [documentation] AW architecture as Resolved.Mar 4 2025, 4:11 PM
Jdforrester-WMF added a subtask: T388298: handle null cases for Scope.Mar 11 2025, 2:07 PM
Jdforrester-WMF added a subtask: T388075: temporarily store visited objects during ZWrapper formation.
Jdforrester-WMF added a subtask: T388174: adjust frequency of alerts.
ecarg closed subtask T379977: Skip idempotent operations in the orchestrator, for performance as Resolved.Mar 11 2025, 3:09 PM
DSmit-WMF closed subtask T386188: Replace anonymous functions returned by Pinia getters with named functions to help with profiling as Resolved.Mar 12 2025, 10:01 AM
DSantamaria removed a subtask: T378782: [spike] install-rust && wasmedge build inconsistent and fails depending on env.Mar 13 2025, 3:12 PM
ecarg closed subtask T388298: handle null cases for Scope as Resolved.Mar 13 2025, 3:38 PM
ecarg removed a subtask: T368892: Enabling the nestedMetadata functionality on Wikifunctions.org causes evaluations to often fail with "gateway timeout" or “service unavailable”.Mar 14 2025, 10:29 PM
ecarg added a subtask: T386433: create a unit test to count recursive calls for builtin zobjects.
ecarg added a subtask: T368892: Enabling the nestedMetadata functionality on Wikifunctions.org causes evaluations to often fail with "gateway timeout" or “service unavailable”.Mar 15 2025, 8:26 PM
ecarg added a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.Mar 15 2025, 8:29 PM
Jdforrester-WMF changed the status of subtask T388174: adjust frequency of alerts from Open to In Progress.Mar 19 2025, 6:15 PM
Jdforrester-WMF added a subtask: T389375: Investigate Latency When Processing Large Objects in Evaluator.Mar 20 2025, 1:10 PM
Jdforrester-WMF added a subtask: T388203: Orchestrator emits very unreadable error: "500: [object Object].
Jdforrester-WMF added a subtask: T388932: orchestrator duration metrics is not working?.
Jdforrester-WMF added a subtask: T383575: Consider using compareTypes in builtin type checking functions.
Jdforrester-WMF added a subtask: T388859: adjust execution duration metric.
DSantamaria changed the status of subtask T383575: Consider using compareTypes in builtin type checking functions from Open to In Progress.Mar 20 2025, 5:59 PM
ecarg closed subtask T388859: adjust execution duration metric as Resolved.Mar 21 2025, 8:13 PM
ecarg closed subtask T385859: increase CPU and Node heap limit? as Resolved.Mar 25 2025, 3:02 PM
ecarg closed subtask T388932: orchestrator duration metrics is not working? as Resolved.Mar 26 2025, 4:31 PM
Jdforrester-WMF removed a subtask: T368892: Enabling the nestedMetadata functionality on Wikifunctions.org causes evaluations to often fail with "gateway timeout" or “service unavailable”.Mar 26 2025, 4:43 PM
ecarg closed subtask T383806: [spike] find out where the delay is coming from as Resolved.Mar 27 2025, 5:18 PM
ecarg removed a subtask: T381597: Consider removing/replacing JSON schemata validators.
ecarg added a subtask: T381597: Consider removing/replacing JSON schemata validators.
Jdforrester-WMF removed a subtask: T388075: temporarily store visited objects during ZWrapper formation.Mar 27 2025, 11:02 PM
ecarg closed subtask T388174: adjust frequency of alerts as Resolved.Mar 28 2025, 8:24 PM
DSantamaria changed the status of subtask T381597: Consider removing/replacing JSON schemata validators from In Progress to Open.Mar 31 2025, 12:36 PM
DSantamaria removed a subtask: T381597: Consider removing/replacing JSON schemata validators.
DSantamaria removed a subtask: T388203: Orchestrator emits very unreadable error: "500: [object Object].Mar 31 2025, 12:42 PM
DSantamaria removed a subtask: T384521: [spike] decide on splitting out built-in code from Orchestrator into Evaluator.Apr 7 2025, 8:04 AM
DSantamaria removed a subtask: T383858: [spike] Decide on whether we want to re-enable or remove the nested metadata feature.
gengh closed subtask T378169: Review front-end performance of convertTableToJson usage as Resolved.Apr 7 2025, 8:53 AM
Jdforrester-WMF closed subtask T383575: Consider using compareTypes in builtin type checking functions as Resolved.Apr 8 2025, 8:30 PM
DSantamaria removed a subtask: T389375: Investigate Latency When Processing Large Objects in Evaluator.Apr 9 2025, 1:50 PM
DSantamaria closed this task as Resolved.Apr 9 2025, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits