Page MenuHomePhabricator

[commons beta-UploadWizard] Missing error in "Uploading someone else work" section when no selection is made
Closed, ResolvedPublic

Description

Notes:

  • found when testing T381333
  • seems like a regression issue - commons wmf.8 behaves correctly

Steps:

  • on commons beta UploadWizard-> Release rights step - select "This work was created by someone else..."
  • don't make any selection and do not fill in any fields.
  • click "Next"

What happened:
The error message says - "There are 2 errors with the form above". In fact, there are three errors: "Please choose why this work is free to share..." section will not display the error.

  • the user is not informed that the selection must be made. After correcting two mistakes, i.e. filling in "Where did you find this work?" and "Enter the name of the original author"
  • the Next button becomes active, clicking on the button won't advance a user to the next step and won't display any other messages.
commons betacommons wmf.8
Screen Shot 2025-01-07 at 2.23.19 PM.png (1×2 px, 319 KB)
Screen Shot 2025-01-07 at 2.22.50 PM.png (1×2 px, 278 KB)

Event Timeline

Change #1109047 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Fix UW error summary

https://gerrit.wikimedia.org/r/1109047

Testing note: After the fix - check both own-not own work options for counting errors summary.

Change #1109047 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Fix UW error summary

https://gerrit.wikimedia.org/r/1109047

Change #1110755 had a related patch set uploaded (by Reedy; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@wmf/1.44.0-wmf.11] Fix UW error summary

https://gerrit.wikimedia.org/r/1110755

Change #1110755 abandoned by Reedy:

[mediawiki/extensions/UploadWizard@wmf/1.44.0-wmf.11] Fix UW error summary

https://gerrit.wikimedia.org/r/1110755