Page MenuHomePhabricator

Terminal brackets in object labels break links on list pages
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Item 174 (currently) is not a link
  • text displayed is “[[Z21327|Testing function for WF:Type conversions]] (Z21327)”

What should have happened instead?:
The object’s label should be displayed as a link to the object. The object’s English label is “Testing function for [[WF:Type conversions]]”.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

I’m not sure whether this should be fixed or simply avoided and documented in https://www.wikifunctions.org/wiki/Wikifunctions:Naming_conventions. I have scanned through all the pages in the list of functions and all other items appear to be formatted correctly as links. Z19255 is a test case that has the same problem (with a single terminal bracket). Z13225, Z13226, Z13227, Z13230, Z13232, Z13234, Z13235, Z15691, Z17716 and Z17764 are other affected test cases. No implementations seem to have this problem.

Event Timeline

I don't need the function anymore, and have posted a request for another admin on RFD. As for avoiding it, that sounds good to me.

Function Z21327 has now been deleted but I have recreated the problem on Z10119 by appending [[Z8]] to its English label. See item 85 on https://www.wikifunctions.org/wiki/Special:ListObjectsByType?orderby=oldest&type=Z8 and note that the terminal “…[[Z8]]” is expanded to “Function (Z8)” (as a link).

Change #1111251 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Escape zobject labels in Special:ListObjectsByType when rendering them in wikitext

https://gerrit.wikimedia.org/r/1111251

Change #1111251 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Escape zobject labels in Special:ListObjectsByType when rendering them in wikitext

https://gerrit.wikimedia.org/r/1111251