Page MenuHomePhabricator

Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language
Closed, ResolvedPublic

Description

When the direction of the interface language is different from the direction of the site content, the feedback comments will likely appear with incorrect direction. I refer to the <blockquote> in which there is a <span> with class="articleFeedbackv5-comment-short".

This scenario is rare, but possible.

There are several possible solutions:

  1. Apply dir="auto" to the <blockquote>. It will work only in Gecko and Webkit and it will work incorrectly in some cases, but should be more flexible.
  1. Apply the direction of the site's language to the <blockquote>. This will work in all browsers, but may be incorrect if the comment was written in a language, the directionality of which is different from the directionality of the site.

Version: unspecified
Severity: normal

Details

Reference
bz36325

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:20 AM
bzimport added projects: ArticleFeedbackv5, I18n.
bzimport set Reference to bz36325.
Amire80 created this task.Apr 28 2012, 8:09 PM

Related URL: https://gerrit.wikimedia.org/r/62807 (Gerrit Change Ifd7c812637bd31e1bbb5784969030fa403efb22f)

Amir: Could you review Matthias' one-liner patch in Gerrit?

Amir: Could you review Matthias' one-liner patch in Gerrit?

Amir: Could you review Matthias' one-liner patch in Gerrit?

Change 62807 merged by jenkins-bot:
(bug 36325) Direction (ltr/rtl) of feedback comments may be different from the direction of the interface language

https://gerrit.wikimedia.org/r/62807