Page MenuHomePhabricator

Broken Echo notification messages in OATHAuth
Closed, ResolvedPublicBUG REPORT

Description

I'm relaying this bug report from another Wikipedia editor who noticed it, so I don't have complete and precise instructions to reproduce it. However, after a quick look at the relevant code, I think it should be fairly easy for the extension's developers to reproduce it.

There are two translatable messages in OATHauth, which don't seem to be correctly configured:

  • notification-header-oathauth-recoverycodes-count
  • notification-body-oathauth-recoverycodesleft

They are probably supposed to appear in an Echo notification after many recovery codes were used. However, they show up in the frontend as ⧼notification-header-oathauth-recoverycodes-count⧽ and ⧼notification-body-oathauth-recoverycodesleft⧽ because these keys don't appear in any en.json files.

The message notification-body-oathauth-recoverycodesleft is probably incorrectly listed in en.json under the key notification-body-oathauth-oathauth-recoverycodesleft. Perhaps simply renaming the key will fix the issue for that message, but it requires testing, and I'm not sure how to do that.

And I don't know what is the other key supposed to be, but OATHAuth developers probably do.

Event Timeline

Change #1122670 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/OATHAuth@master] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1122670

This was introduced with T131788

After my patch

Screenshot 2025-02-25 at 22.36.19.png (1×1 px, 294 KB)

We should probably discuss the content for the header, i just wrote something down for having something in the patch.
Additionally, this might require backporting to 1.39, 1.41, 1.42 and 1.43

Change #1122670 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1122670

Change #1123054 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/extensions/OATHAuth@REL1_42] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123054

Change #1123055 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/extensions/OATHAuth@REL1_43] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123055

Change #1123056 had a related patch set uploaded (by Reedy; author: TheDJ):

[mediawiki/extensions/OATHAuth@REL1_39] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123056

Change #1123056 abandoned by Reedy:

[mediawiki/extensions/OATHAuth@REL1_39] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123056

Change #1123055 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_43] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123055

Change #1123054 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@REL1_42] Fix translations for recovery code notifications

https://gerrit.wikimedia.org/r/1123054

Reedy assigned this task to TheDJ.