Page MenuHomePhabricator

Accesskey tooltips for Firefox 14 on Mac should use "ctrl-option-" prefix
Closed, ResolvedPublic

Description

“ctrl-option-” for Firefox 14+ on Mac; “ctrl-alt-” → “ctrl-option-” for Safari on Mac

Firefox has switched to Ctrl+Opt for accesskeys on the Mac as of version 14. [1][2] The file resources/mediawiki/mediawiki.util.js needs to be adjusted to use the right prefix in tooltips.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=728103
[2] https://developer.mozilla.org/en/HTML/Global_attributes#attr-accesskey


Version: 1.20.x
Severity: normal
URL: https://bugzilla.mozilla.org/show_bug.cgi?id=728103

attachment tooltipAccessKeyPrefix.patch ignored as obsolete

Details

Reference
bz36329

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:20 AM
bzimport set Reference to bz36329.
mxn created this task.Apr 28 2012, 10:30 PM

sumanah wrote:

Thanks, Minh Nguyễn! Please request developer access

https://www.mediawiki.org/wiki/Developer_access

so you can easily suggest these fixes directly via Git next time. Thanks for the patch.

mxn added a comment.Apr 30 2012, 3:28 PM

No problem. I’ll look into requesting access.

sumanah wrote:

Thanks again for the patch. Have you had any trouble in using developer access to directly suggest it into our Git source control system?

https://www.mediawiki.org/wiki/Developer_access

https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch

See also bug 37239.

(In reply to comment #4)

https://gerrit.wikimedia.org/r/#/c/17687/

Wrong bug?

(In reply to comment #5)

See also bug 37239.

(In reply to comment #4)

https://gerrit.wikimedia.org/r/#/c/17687/

Wrong bug?

yes.

should be: https://gerrit.wikimedia.org/r/#/c/17689/

Removing "patch-need-review" keyword. This is now in the Gerrit queue, there is no patch to review here on BugZilla.