| Nardog | |
| Jan 9 2025, 12:26 PM |
| F58363986: image.png | |
| Feb 5 2025, 5:11 PM |
| F58152997: image.png | |
| Jan 9 2025, 12:26 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
The warning "There is no video associated with the current subtitle page" is horizontally squeezed to the point that each line has only one letter.
What should have happened instead?:
The warning appears normally.
Other information:
The culprit appears to be:
.oo-ui-labelWidget { display: inline-block; }
It's using a Codex box inside an OOUI element for some reason.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| TimedTextPage: Move error/warning box before the form | mediawiki/extensions/TimedMediaHandler | master | +1 -5 |
likely caused by https://gerrit.wikimedia.org/r/1074283 (T360668), which removed non-codex output for the message box methods. One solution would be to switch from html::errorBox and html::warningBox to the OOUI messageWidget(Type: Warning) and MessageBox(Type: Error)
What the heck ? Interesting combo of options is in play here indeed.
The cdx-message-content has its width set to 0, with flex-basis: auto (which should thus default to 0) AND has break anywhere... Which makes it strive to be 0, which indeed requires applying as much line breaking as possible.
But if you remove the width:0 it works. If you remove the width AND set flex-basis: 0 it STILL works (which as far as I know, should be the exact same, but I guess not under some of the line breaking rules)
ping @Volker_E
I don't understand why this message is inside of a label...it looks fine if you move the message outside of the label (even if it's still within the OOUI field):
Maybe someone can fix the placement?
Change #1117979 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/TimedMediaHandler@master] TimedTextPage: Move error/warning box before the form
Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/a83096dc89/wiki/TimedText:Example
Change #1117979 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] TimedTextPage: Move error/warning box before the form
Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted: