servicelib-golang logger missing required version attribute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Eevans
	Jan 9 2025, 9:35 PM

Description

The logger in servicelib-golang is missing the required ecs.version attribute. As a result, log messages are going to the default/legacy index (not the ecs-specific one), and some attributes (log.level for example) are not being parsed/flattened).

For example:

WARNING: This will be a breaking/fixing change. Breaking in that existing dashboards will need to be fixed. Fixed in that the messages will be correctly routed and parsed.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Upgrade date-gateway service to v1.0.11	operations/deployment-charts	master	+1 -1
	Use an `ecs.version` as required	mediawiki/services/servicelib-golang	master	+13 -0

Customize query in gerrit

Related Objects

Mentioned In: rMSGO6d11dd23a19c: Use an `ecs.version` as required

Event Timeline

Eevans created this task.Jan 9 2025, 9:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2025, 9:35 PM

Eevans triaged this task as Medium priority.Jan 9 2025, 9:36 PM

Change #1109500 had a related patch set uploaded (by Eevans; author: Eevans):

[mediawiki/services/servicelib-golang@master] Use an `ecs.version` as required

https://gerrit.wikimedia.org/r/1109500

gerritbot added a project: Patch-For-Review.Jan 9 2025, 9:48 PM

Change #1109500 merged by Eevans:

[mediawiki/services/servicelib-golang@master] Use an `ecs.version` as required

https://gerrit.wikimedia.org/r/1109500

Eevans mentioned this in rMSGO6d11dd23a19c: Use an `ecs.version` as required.Jan 10 2025, 2:02 AM

This is fixed in v1.0.0.

$ go get gerrit.wikimedia.org/r/mediawiki/services/servicelib-golang@v1.0.0

Eevans closed this task as Resolved.Jan 10 2025, 2:18 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2025, 2:30 AM

Change #1109722 had a related patch set uploaded (by Eevans; author: Eevans):

[operations/deployment-charts@master] Upgrade to v1.0.11

https://gerrit.wikimedia.org/r/1109722

gerritbot added a project: Patch-For-Review.Jan 10 2025, 3:16 PM

Just to clarify, IIUC, this will only break logging dashboards, right?
So, if we had no associated logging dashboards, then this would be a no-op?
🙏

In T383371#10448563, @mforns wrote:

Just to clarify, IIUC, this will only break logging dashboards, right?
So, if we had no associated logging dashboards, then this would be a no-op?
🙏

Right, it's actually a fix that you want (the events won't be parsed by logstash correctly otherwise), but if you had any existent dashboards, you'd need to update the source index pattern (to ecs-*, from logstash-*), or they would stop working.

Change #1109722 merged by jenkins-bot:

[operations/deployment-charts@master] Upgrade date-gateway service to v1.0.11