Page MenuHomePhabricator
Create Task
Maniphest T383390

Comments do not show up without <comment-streams-toc />
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
BlankEclair
Authored By
BlankEclair
Jan 10 2025, 11:30 AM
Tags
Referenced Files
F58161276: Screenshot 2025-01-10 at 22-28-32 CommentStreams_WithCommentList - my_wiki.png
Jan 10 2025, 11:30 AM
F58161270: Screenshot 2025-01-10 at 22-28-10 my_wiki.png
Jan 10 2025, 11:30 AM
F58161268: Screenshot 2025-01-10 at 22-27-55 my_wiki.png
Jan 10 2025, 11:30 AM
Subscribers
Aklapper
BlankEclair
cicalese
Reception123

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Comments don't display:

Screenshot 2025-01-10 at 22-27-55 my_wiki.png (1×3 px, 268 KB)

What should have happened instead?:
Comments should've displayed:

Screenshot 2025-01-10 at 22-28-10 my_wiki.png (1×3 px, 351 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

  • MediaWiki: 1.42.3 (e14367f) 06:02, 5 December 2024
  • PHP: 8.1.20 (fpm-fcgi)
  • MariaDB: 11.4.2-MariaDB
  • CommentStreams: 8.0.2 (a74591a) 06:06, 9 January 2025

Other information (browser name/version, screenshots, etc.):
This was initially reported downstream to Miraheze: https://issue-tracker.miraheze.org/T13070

For pages with the <comment-streams-toc /> tag, comments render fine:

Screenshot 2025-01-10 at 22-28-32 CommentStreams_WithCommentList - my_wiki.png (1×3 px, 666 KB)

This was caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommentStreams/+/1098671

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix displaying comments on pages without <comment-streams-toc />mediawiki/extensions/CommentStreamsREL1_43+1 -0
Fix displaying comments on pages without <comment-streams-toc />mediawiki/extensions/CommentStreamsmaster+1 -0
Fix displaying comments on pages without <comment-streams-toc />mediawiki/extensions/CommentStreamsREL1_42+4 -0
Customize query in gerrit

Related Objects

Event Timeline

BlankEclair created this task.Jan 10 2025, 11:30 AM
Restricted Application added subscribers: Reception123, Aklapper. · View Herald TranscriptJan 10 2025, 11:30 AM
BlankEclair claimed this task.Jan 10 2025, 11:31 AM
gerritbot added a comment.Jan 10 2025, 11:37 AM

Change #1109689 had a related patch set uploaded (by BlankEclair; author: BlankEclair):

[mediawiki/extensions/CommentStreams@REL1_42] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1109689

gerritbot added a project: Patch-For-Review.Jan 10 2025, 11:37 AM
gerritbot added a comment.Jan 11 2025, 4:56 PM

Change #1110044 had a related patch set uploaded (by MarkAHershberger; author: BlankEclair):

[mediawiki/extensions/CommentStreams@master] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1110044

gerritbot added a comment.Jan 11 2025, 4:57 PM

Change #1109689 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_42] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1109689

BlankEclair mentioned this in rECOS4478b58478ff: Fix displaying comments on pages without <comment-streams-toc />.Jan 11 2025, 4:58 PM
gerritbot added a comment.Jan 11 2025, 5:03 PM

Change #1110044 abandoned by MarkAHershberger:

[mediawiki/extensions/CommentStreams@master] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1110044

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2025, 5:30 PM
BlankEclair closed this task as Resolved.Jan 12 2025, 1:45 AM
cicalese reopened this task as Open.Jan 19 2025, 2:11 PM
cicalese subscribed.

Reopening since the patch was only applied to the Release 1.42 branch. Was it fixed in another patch on master and the Release 1.43 branch?

gerritbot added a comment.Jan 19 2025, 3:50 PM

Change #1110044 restored by MarkAHershberger:

[mediawiki/extensions/CommentStreams@master] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1110044

gerritbot added a project: Patch-For-Review.Jan 19 2025, 3:50 PM
gerritbot added a comment.Jan 19 2025, 4:23 PM

Change #1110044 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1110044

MarkAHershberger mentioned this in rECOSc5ff7c51a1cc: Fix displaying comments on pages without <comment-streams-toc />.Jan 19 2025, 4:23 PM
cicalese moved this task from Backlog to Waiting for Merge on the MediaWiki-extensions-CommentStreams board.Jan 19 2025, 4:42 PM
MarkAHershberger closed this task as Resolved.Jan 19 2025, 4:44 PM
cicalese moved this task from Waiting for Merge to Closed on the MediaWiki-extensions-CommentStreams board.Jan 19 2025, 4:48 PM
gerritbot added a comment.Jan 19 2025, 5:23 PM

Change #1112396 had a related patch set uploaded (by MarkAHershberger; author: BlankEclair):

[mediawiki/extensions/CommentStreams@REL1_43] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1112396

BlankEclair added a comment.Jan 20 2025, 1:29 AM
In T383390#10474442, @cicalese wrote:

Reopening since the patch was only applied to the Release 1.42 branch. Was it fixed in another patch on master and the Release 1.43 branch?

At the time, it was caused by https://gerrit.wikimedia.org/r/1098671, which was for REL1_42. On master, the changeset for it (https://gerrit.wikimedia.org/r/1020437) was in a merge conflict (and so did not affect that branch), therefore I made a comment asking to essentially add my fix from REL1_42 into the same patch, and he complied. The patch for adding the feature didn't exist for REL1_43 at the time.

gerritbot added a comment.Feb 4 2025, 3:06 PM

Change #1112396 merged by Robert Vogel:

[mediawiki/extensions/CommentStreams@REL1_43] Fix displaying comments on pages without <comment-streams-toc />

https://gerrit.wikimedia.org/r/1112396

MarkAHershberger mentioned this in rECOS32bea3a65d56: Fix displaying comments on pages without <comment-streams-toc />.Feb 4 2025, 3:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits