@KStoller-WMF During estimation, we were not sure what the specification should be. Moving to Needs Discussion.

@JFernandez-WMF will review and add design specs.

there's a specification on when a quantity gate is reached while the task is open — see example screenshot (for add an image):
we should be using a post-edit dialog that suggests editing another article.

desktop
mobile

@JFernandez-WMF Thanks for the screenshots! I'm a bit confused though. At the desktop screenshot, the system tells me I completed all Add Image tasks that are available, but it also suggests me to look at another Add Image task? Wouldn't I see an error message if I click at that article? For some reason, the mobile screenshot suggests Find references in the same situation. Is that intended?

More generally, it is not clear to me how would we determine what task type should be suggested to the user. Should it be selected randomly? Or perhaps that is not a good idea, and we should have some system for determining what task type to select. Maybe we should be recommending the easiest available task? If so, what would we do if there is more than one easiest task type? Would we use random selection in that case?

Should we be respecting the task types the user enabled on their homepage? If so, what would we do if the user has only Add Link enabled? Would we ask them to change their settings, or would we ignore their settings instead?

Unfortunately, the answers to those questions are not clear to me. Because the task is currently not actionable from an engineering perspective, I'm putting it back to Needs Discussion. Hopefully the questions I mentioned above would help in fully specifying the desired behaviour here.

FYI @KStoller-WMF as well.

I was a bit confused because I thought this was just a regression, and that there was previous work and logic in place here (I think this is the original related task: T274325).
Julieta attached designs from the “Add an image: quality gate” work. I think it was just meant to convey the design, not the logic.

It is not clear to me how would we determine what task type should be suggested to the user. Should it be selected randomly?

My suggestion is that it should be respecting the task types the user enabled on their homepage. UNLESS the user only has tasks enabled (like “add a link” and “add an image” where the quality gate limit is reached. Then I think it’s OK to suggest random Suggested Edits (that exclude tasks where the quality gate limit is reached).

Should we be respecting the task types the user enabled on their homepage? If so, what would we do if the user has only Add Link enabled? Would we ask them to change their settings, or would we ignore their settings instead?

If there are no suggestions available due to the user’s task settings or quality gates, then I personally think it’s OK to simply ignore their settings. It might be ideal to also suggest they “level up” or change their settings, but I think we should just make this look less broken and minimize complexity.

In T383433#10510643, @KStoller-WMF wrote:

I was a bit confused because I thought this was just a regression, and that there was previous work and logic in place here (I think this is the original related task: T274325).

@KStoller-WMF - yes, we implemented the scenarios where there was no more tasks available. As far as I recall, those were

• a user selected on Special:Homepage some combination of task type/topic(s) and finished editing all of them.So, based on the filter selection, there were no more tasks available
• a user reached quiality gate quota and didn't have other task types in the filter selection In https://phabricator.wikimedia.org/T311893#8134505 there are results of testing those scenarios with screenshots. Also, T293316: Add an image: minimal quality gate has detailed description of those scenarios.

Especially the screenshots from T311893#8134505 as shared by @Etonkovidova are instructive. Thank you for digging them up!
Apparently, we used to have a well-defined and working behavior for what happens if someone runs out of Add Link tasks for the day, depending on whether they have more other tasks available on the homepage or not. I think this is good enough for us to start with a spike into figuring out why that stopped working.

@KStoller-WMF Should we move this task forward?

If this is actionable, then yes, let's move this to Up Next.

This seems a regression from T331980: Post edit dialog: "No suggestions" content does not display, I believe we changed somewhere the order in which TASK_QUEUE_CHANGED and TASK_QUEUE_LOADING are triggered which may explain it, looking into it and if there are or should be some e2e tests for this.

Change #1139099 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] fix(PostEditPanel): re-render main area when task queue finishes loading

https://gerrit.wikimedia.org/r/1139099

Change #1139099 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(PostEditPanel): re-render main area when task queue finishes loading

https://gerrit.wikimedia.org/r/1139099