Maniphest T383459

System Nav Bar [Bug] - Code Cleanup
Open, LowPublic
Actions

Assigned To

None

Authored By

	Tsevener
	Jan 11 2025, 12:06 AM

Tags

Referenced Files

None

Subscribers

Description

Sometimes "Edit" on Reading Lists causes assertion failure
The old ViewController class had ArticlePreviewingDelegate. It has been added it to ColumnarCollectionViewController after ViewController was deleted. Is it needed anywhere else? This would cause a bug where long presses do not show an article preview.
Code cleanup: There's some code duplication in WMFReferencePageViewController.swift (see didFinishAnimating method) and ReferenceShowing.swift (see showReferences method). Can these be deduped?

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		HNordeenWMF	T383897 [Tech Debt Epic] Move to System Navigation Bar
		Open		None	T398263 Clean up from System Navigation Changes
		Open		None	T383459 System Nav Bar [Bug] - Code Cleanup

Event Timeline

Tsevener created this task.Jan 11 2025, 12:06 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2025, 12:06 AM

Tsevener mentioned this in T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar.Jan 11 2025, 12:08 AM

Tsevener renamed this task from System Nav Bar - Code Cleanup to System Nav Bar [Bug] - Code Cleanup.Jan 13 2025, 3:29 PM

Tsevener triaged this task as Low priority.Jan 16 2025, 2:25 PM

HNordeenWMF mentioned this in T383897: [Tech Debt Epic] Move to System Navigation Bar.Jan 16 2025, 3:21 PM

HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.Jan 23 2025, 6:51 PM

HNordeenWMF moved this task from Up next to iOS Release FY2024-25 on the Wikipedia-iOS-App-Backlog board.Jan 27 2025, 6:17 PM

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.

HNordeenWMF mentioned this in T379440: [Sub-Epic] Navigation Refresh Part 2 - Search Improvements - Jan/Feb 2025.Feb 4 2025, 5:39 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 11 2025, 1:02 AM

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).Feb 13 2025, 3:24 PM

HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.Feb 13 2025, 3:25 PM

HNordeenWMF added a parent task: T398263: Clean up from System Navigation Changes.Jul 1 2025, 12:10 AM

HNordeenWMF moved this task from Up next to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Jul 1 2025, 12:13 AM