Maniphest T383460

System Nav Bar [Design Review] - Finalize Done / Cancel buttons
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

None

Authored By

	Tsevener
	Jan 11 2025, 12:09 AM

Tags

Referenced Files

None

Subscribers

Description

Address feedback in https://phabricator.wikimedia.org/T363606#10445694. Ensure (as much as is easy) text / alignment fixes flow through the WMFNavigationBarConfiguring configureNavigationBar method.

The X close buttons will be updated separately.

Related Objects

Mentioned In: T384639: Unable to create reading lists while logged out
T383897: [Tech Debt Epic] Move to System Navigation Bar
T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar
Mentioned Here: T384845: Update remaining X close buttons
T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar

Event Timeline

Tsevener created this task.Jan 11 2025, 12:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2025, 12:09 AM

Tsevener mentioned this in T363606: [XL] [Tech Debt] Replace custom navigation bar with system bar.Jan 11 2025, 12:15 AM

Tsevener renamed this task from System Nav Bar - Finalize Done / Cancel buttons to System Nav Bar [Design Review] - Finalize Done / Cancel buttons.Jan 13 2025, 3:29 PM

HNordeenWMF mentioned this in T383897: [Tech Debt Epic] Move to System Navigation Bar.Jan 16 2025, 3:21 PM

HNordeenWMF triaged this task as Low priority.Jan 16 2025, 11:58 PM

This should be done before system nav bar goes to Beta to avoid confusing interfaces with two "Done" buttons

Mazevedo set the point value for this task to 3.Jan 23 2025, 6:20 PM

Mazevedo moved this task from Needs Eng Sync or Estimation to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 23 2025, 6:28 PM

Mazevedo added a project: iOS Sprint 2025: Cairo.Jan 23 2025, 6:32 PM

Mazevedo claimed this task.Jan 23 2025, 8:10 PM

Mazevedo moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener mentioned this in T384639: Unable to create reading lists while logged out.Jan 23 2025, 10:21 PM

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/5168

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 24 2025, 5:29 PM

Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 24 2025, 9:28 PM

Mazevedo moved this task from Did not pass Code Review to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 27 2025, 2:34 PM

The close buttons with an X or SFSymbols that were not in the system nav bar will be updated here
https://phabricator.wikimedia.org/T384845

Mazevedo updated the task description. (Show Details)Jan 27 2025, 4:07 PM

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 27 2025, 4:15 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5168

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 27 2025, 9:23 PM

Available to test on 7.7.0 (4870)

Looks good on 7.7.0 (4878)

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 30 2025, 7:13 PM

HNordeenWMF closed this task as Resolved.Jan 30 2025, 10:07 PM

HNordeenWMF removed Mazevedo as the assignee of this task.

HNordeenWMF added a subscriber: Mazevedo.