Page MenuHomePhabricator

System Nav Bar [Design Review] - Places search fixes
Open, LowPublic

Assigned To
None
Authored By
Tsevener
Jan 11 2025, 12:14 AM
Referenced Files
F58394932: IMG_F08798FFB9A7-1.jpeg
Feb 13 2025, 12:10 PM
F58385455: image.png
Feb 11 2025, 10:46 AM
F58385434: IMG_1028.PNG
Feb 11 2025, 10:46 AM
F58385433: IMG_1029.PNG
Feb 11 2025, 10:46 AM
F58385402: 0847C16A-0DB7-4E91-A776-35B146AA0433_1_102_o.jpeg
Feb 11 2025, 10:46 AM
F58385404: C3916FD2-C828-4527-A5E6-EFE1F000310A_1_102_o.jpeg
Feb 11 2025, 10:46 AM

Description

From https://phabricator.wikimedia.org/T363606#10301172

  1. It seems like the Places search bar has a different background color than, e.g., "Explore" and "Saved." Can we use the same color (from Explore) for all?

https://phabricator.wikimedia.org/T363606#10409759

  1. Labels:

a) Align the Places search label with the other search labels:

More details:

@scblr @HNordeenWMF - the spacing issue seems to be the component adjusting the text to the space available - in the screenshots below, in Portuguese, the text is longer on both screens, and the spacing is consistent. We have no control over that part of the component in this case.

Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.41.png (2×1 px, 155 KB)

Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.33.png (2×1 px, 1 MB)

Hmm, this is weird! It doesn’t adjust the space in current production! ⬇️

C3916FD2-C828-4527-A5E6-EFE1F000310A_1_102_o.jpeg (2×1 px, 226 KB)
0847C16A-0DB7-4E91-A776-35B146AA0433_1_102_o.jpeg (2×1 px, 619 KB)

I checked French and German in Experimental build 7.7.1.221 , where the problem (gap between icon + label) is occurring as well with various string lengths:

IMG_1029.PNG (2×1 px, 1 MB)
IMG_1028.PNG (2×1 px, 1 MB)

In Portuguese (Brazil) as well on my device! ⬇️ 🤔

image.png (2×1 px, 1 MB)

Event Timeline

Tsevener renamed this task from System Nav Bar - Align Places search label to System Nav Bar [Design Review] - Align Places search label.Jan 13 2025, 3:29 PM
Tsevener renamed this task from System Nav Bar [Design Review] - Align Places search label to System Nav Bar [Design Review] - Places search fixes.Jan 15 2025, 11:13 PM
Tsevener updated the task description. (Show Details)

@Mazevedo

iPhone 15 Pro on iOS 18.3, with this dynamic text size setting:

IMG_F08798FFB9A7-1.jpeg (2×1 px, 292 KB)

Thanks @scblr! I'll check it in more device sizes with dynamic text on