PHP Warning: Stats: Cannot add labels to a metric containing samples for 'update_mentee_data_seconds'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

service.version: 1.44.0-wmf.11
trace.id: 99fdd4c1a55b2723705a453b
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   PHP Warning: Stats: Cannot add labels to a metric containing samples for 'update_mentee_data_seconds'

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.11/includes/libs/Stats/Metrics/MetricTrait.php(95)
#0	[internal function]	MWExceptionHandler::handleError(int, string, string, int, array)
#1	/srv/mediawiki/php-1.44.0-wmf.11/includes/libs/Stats/Metrics/MetricTrait.php(95)	trigger_error(string, int)
#2	/srv/mediawiki/php-1.44.0-wmf.11/extensions/GrowthExperiments/maintenance/updateMenteeData.php(177)	Wikimedia\Stats\Metrics\TimingMetric->setLabel(string, string)
#3	/srv/mediawiki/php-1.44.0-wmf.11/maintenance/includes/MaintenanceRunner.php(703)	GrowthExperiments\Maintenance\UpdateMenteeData->execute()
#4	/srv/mediawiki/php-1.44.0-wmf.11/maintenance/run.php(51)	MediaWiki\Maintenance\MaintenanceRunner->run()
#5	/srv/mediawiki/multiversion/MWScript.php(156)	require_once(string)
#6	{main}

Impact

Notes

A lot of these warnings whenever the script runs. Related T374048

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix failing UpdateMenteeData.php script	mediawiki/extensions/GrowthExperiments	master	+1 -4

Customize query in gerrit

Related Objects

Mentioned In: T374048: Migrate GrowthExperiments.Mentorship Module to statslib
Mentioned Here: T383208: StatsLib timings MUST be recorded as milliseconds
T374048: Migrate GrowthExperiments.Mentorship Module to statslib

Event Timeline

Ammarpad created this task.Jan 11 2025, 6:26 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 11 2025, 6:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Follow-up to the work from T374048, moving to sprint.

@Cyndymediawiksim, would you be able to take a look at this? FYI to @Sgs.

I'm also wondering how much related this is to T383208: StatsLib timings MUST be recorded as milliseconds. @Michael @Sgs, do you know?

You added label "section" to the "profiling" (173-177) part, but the label structure and first sample(s) were created at the "total time" part (164-170). Creating new label keys is not allowed when some data is already collected.

Cyndymediawiksim changed the task status from Open to In Progress.Jan 13 2025, 12:34 PM

Cyndymediawiksim claimed this task.

Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.

Change #1110766 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Fix failing UpdateMenteeData.php script

https://gerrit.wikimedia.org/r/1110766

gerritbot added a project: Patch-For-Review.Jan 13 2025, 12:37 PM

Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Jan 13 2025, 5:07 PM

Ammarpad merged a task: T383824: PHP Warning: Stats: Cannot add labels to a metric containing samples for 'update_mentee_data_seconds'.Jan 16 2025, 9:00 AM

Ammarpad added a subscriber: TheresNoTime.

Cyndymediawiksim moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Jan 17 2025, 2:31 PM

Change #1110766 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix failing UpdateMenteeData.php script

https://gerrit.wikimedia.org/r/1110766

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 17 2025, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2025, 4:30 PM

The error seem to stop completely - the logstash link. The last timestamp - Jan 23, 2025 @ 19:24:31.268

Etonkovidova closed this task as Resolved.Jan 30 2025, 1:11 AM

Krinkle moved this task from Untriaged to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:42 AM

PHP Warning: Stats: Cannot add labels to a metric containing samples for 'update_mentee_data_seconds'Closed, ResolvedPublicPRODUCTION ERRORActions