Page MenuHomePhabricator
Create Task
Maniphest T383555

Add support for reading new file schema in MediaModeration
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

See parent task T28741 for more details.

This task is to track progress of updating the MediaModeration extension to support reading the new file schema (which is described in T28741 in the 'Approved changes' section). The schema migration configuration that is controlling this is wgFileSchemaMigrationStage

We need to have this ready by March per T383496#10452849.

Acceptance criteria
  • The MediaModeration extension works the same when wgFileSchemaMigrationStage is set to SCHEMA_COMPAT_READ_NEW or SCHEMA_COMPAT_READ_OLD
  • The MediaModeration extension tests pass when wgFileSchemaMigrationStage is set to SCHEMA_COMPAT_READ_NEW

Details

Due Date
Mar 1 2025, 12:00 AM
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update remaining MediaModeration tests to insert to new file schemamediawiki/extensions/MediaModerationmaster+159 -15
Update InsertMockFileDataTrait to also insert to new schemamediawiki/extensions/MediaModerationmaster+134 -4
Insert mock file rows once per class in integration testsmediawiki/extensions/MediaModerationmaster+50 -48
De-duplicate inserts to image, oldimage, and filearchive for testsmediawiki/extensions/MediaModerationmaster+222 -439
Update tests to support file schema migrationmediawiki/extensions/MediaModerationmaster+40 -737
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedZabeT383496 Add support for reading new file schema into MediaWiki
ResolvedDreamy_JazzT383555 Add support for reading new file schema in MediaModeration
· · ·

Event Timeline

Dreamy_Jazz created this task.Jan 13 2025, 11:37 AM
Dreamy_Jazz mentioned this in T383496: Add support for reading new file schema into MediaWiki.
Dreamy_Jazz set Due Date to Mar 1 2025, 12:00 AM.
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)).Jan 13 2025, 11:39 AM
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 20 2025, 3:21 PM
Dreamy_Jazz claimed this task.Jan 20 2025, 4:16 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.
Dreamy_Jazz changed the task status from Open to Stalled.Jan 20 2025, 4:43 PM
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.
Dreamy_Jazz moved this task from In Progress to Priority Backlog on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.

Work on this cannot proceed until MediaWiki core is updated to support reading new in the FileSelectQueryBuilder because apart from test code we don't usually interact with the file tables without using that query builder.

Therefore marking this as stalled and moving back to the sprint backlog.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 21 2025, 2:21 PM

A patch does exist for supporting FileSelectQueryBuilder, but that patch is now blocked on tests from this extension. Upgrading the tests should help avoid this.

Dreamy_Jazz changed the task status from Stalled to Open.Jan 21 2025, 2:22 PM
gerritbot added a comment.Jan 21 2025, 3:05 PM

Change #1113160 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Update tests to support file schema migration

https://gerrit.wikimedia.org/r/1113160

gerritbot added a project: Patch-For-Review.Jan 21 2025, 3:05 PM
gerritbot added a comment.Jan 22 2025, 1:01 AM

Change #1113160 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Update tests to support file schema migration

https://gerrit.wikimedia.org/r/1113160

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2025, 1:30 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.14; 2025-01-28).Jan 22 2025, 2:00 AM
gerritbot added a comment.Jan 22 2025, 7:14 PM

Change #1113526 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] [WIP] De-duplicate inserts to image, oldimage, and filearchive for tests

https://gerrit.wikimedia.org/r/1113526

gerritbot added a project: Patch-For-Review.Jan 22 2025, 7:14 PM
Dreamy_Jazz claimed this task.Jan 23 2025, 2:59 PM
Dreamy_Jazz set the point value for this task to 3.
Dreamy_Jazz changed the point value for this task from 3 to 2.
gerritbot added a comment.Jan 23 2025, 3:07 PM

Change #1113819 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Insert mock file rows once per class in integration tests

https://gerrit.wikimedia.org/r/1113819

gerritbot added a comment.Jan 23 2025, 3:11 PM

Change #1113526 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] De-duplicate inserts to image, oldimage, and filearchive for tests

https://gerrit.wikimedia.org/r/1113526

gerritbot added a comment.Jan 23 2025, 4:21 PM

Change #1113836 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Update InsertMockFileDataTrait to also insert to new schema

https://gerrit.wikimedia.org/r/1113836

gerritbot added a comment.Jan 23 2025, 4:21 PM

Change #1113837 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Update remaining MediaModeration tests to insert to new file schema

https://gerrit.wikimedia.org/r/1113837

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 23 2025, 4:25 PM
Dreamy_Jazz updated the task description. (Show Details)
gerritbot added a comment.Jan 23 2025, 4:55 PM

Change #1113819 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Insert mock file rows once per class in integration tests

https://gerrit.wikimedia.org/r/1113819

gerritbot added a comment.Jan 23 2025, 5:27 PM

Change #1113836 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Update InsertMockFileDataTrait to also insert to new schema

https://gerrit.wikimedia.org/r/1113836

gerritbot added a comment.Jan 23 2025, 5:27 PM

Change #1113837 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Update remaining MediaModeration tests to insert to new file schema

https://gerrit.wikimedia.org/r/1113837

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2025, 5:30 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 23 2025, 6:51 PM

For QA I would suggest ignoring the second acceptance criteria as that is verified through the PHPUnit tests passing.

To verify the first step I would suggest using the QA steps I detailed at T354408#9460927, doing this once with $wgFileSchemaMigrationStage = SCHEMA_COMPAT_OLD; set and then once with $wgFileSchemaMigrationStage = SCHEMA_COMPAT_NEW; set. You should see no difference in the results of the steps depending on the value of $wgFileSchemaMigrationStage.

Dreamy_Jazz updated the task description. (Show Details)Jan 24 2025, 10:38 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 25 2025, 8:11 AM
Djackson-ctr subscribed.

QA is completed, I have verified the new code has been implemented and is functioning as expected... Thank you for the QA Steps @Dreamy_Jazz.
Below is one of the configurations I used for $wgMediaModerationPhotoDNAMockServiceFiles, and then I verified the results of the mediamoderation_scan db table with $wgFileSchemaMigrationStage = SCHEMA_COMPAT_OLD; and then did the same for $wgFileSchemaMigrationStage = SCHEMA_COMPAT_NEW;

image.png (326×591 px, 22 KB)

image.png (413×759 px, 77 KB)

kostajh closed this task as Resolved.Jan 25 2025, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits