IP Reveal onboarding dialog does not maintain the status of the "Enable IP Info" checkbox after checking
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 13 2025, 12:00 PM

Description

What is the problem?

On the second page of the IP Reveal onboarding dialog, if you check the Enable IP Info checkbox and click the next or back button, the checked status is lost and when you go back to the second page it is unchecked.

Steps to reproduce problem

On an environment with CheckUser and IP Info installed and $wgCheckUserEnableTempAccountsOnboardingDialog = true;
Login as a user with checkuser-temporary-account-viewer and ipinfo-view-basic or ipinfo-view-full rights
Go to Special:Preferences and under "IP Information" make sure it is unchecked (uncheck it and submit if not)
Go to Special:RecentChanges
A dialog should appear, click the next button
There should be a "Enable IP Information" heading with a checkbox underneath. Check the checkbox.
Click back and then forward (or forward and then back)

Expected behaviour: Checkbox is still checked.
Observed behaviour: Checkbox is unchecked.

Environment

Browser: Chromium 131.
Wiki(s): local docker CheckUser 2.5 (0304c58) 07:23, 13 January 2025. IP Info 0.0.0 (38276ee) 07:24, 13 January 2025.

Screenshots

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Persist IPInfo checked status in temporary accounts dialog	mediawiki/extensions/CheckUser	master	+68 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Niharika	T373818 [Epic] Guidance for discovery of IP Reveal feature
		Resolved	BUG REPORT	Dreamy_Jazz	T383556 IP Reveal onboarding dialog does not maintain the status of the "Enable IP Info" checkbox after checking

Event Timeline

dom_walden created this task.Jan 13 2025, 12:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2025, 12:00 PM

Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Jan 13 2025, 12:40 PM

Dreamy_Jazz claimed this task.Jan 13 2025, 2:31 PM

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.

Dreamy_Jazz moved this task from Sprint Chimes (Dec. 9 - Jan. 17) to Sprint Tuba (Jan 20 - Feb 7) on the Trust and Safety Product Sprint board.Jan 15 2025, 2:56 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)); removed Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).

Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.

Dreamy_Jazz added a parent task: T373818: [Epic] Guidance for discovery of IP Reveal feature.Feb 6 2025, 2:45 PM

Change #1117915 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [Very WIP] Make IPInfo preference global

https://gerrit.wikimedia.org/r/1117915

gerritbot added a project: Patch-For-Review.Feb 6 2025, 2:45 PM

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)); removed Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)).Feb 10 2025, 10:01 AM

kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.

Change #1120608 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Persist IPInfo checked status in temporary accounts dialog

https://gerrit.wikimedia.org/r/1120608

Dreamy_Jazz moved this task from Ready to Needs Review on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 19 2025, 10:55 PM

Dreamy_Jazz mentioned this in T386880: Temporary accounts onboarding dialog: Show the dialog when the user does not have the IP reveal preference checked.Feb 19 2025, 11:08 PM

Change #1120608 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Persist IPInfo checked status in temporary accounts dialog

https://gerrit.wikimedia.org/r/1120608

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Feb 20 2025, 11:00 AM

One additional thing to note for QA is that the IP Info step will not display the preference if the user has checked the preference, navigates to a different step, and then navigates back to the second IPInfo step. This is because the preference is hidden if it has been checked before the step content is shown.

After checking the IPInfo checkbox on the second page and saving, switching to a different page and then back again no longer shows the checkbox.

As pointed out in the commit notes:

This means that if the user unchecks the preference in Special:Preferences and then reloads the dialog, the preference will [not be shown]. However, this should be not an expected user flow and therefore should be fine to ignore.

Thanks.

Dreamy_Jazz removed a project: Patch-For-Review.Feb 20 2025, 3:06 PM

IP Reveal onboarding dialog does not maintain the status of the "Enable IP Info" checkbox after checkingClosed, ResolvedPublicBUG REPORTActions