Page MenuHomePhabricator

Consider Returning `ZWrapper`s from builtin functions
Closed, ResolvedPublic

Description

Description

This will avoid some superfluous asJSON calls and possibly improve the coming "pre-validation" flow.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • decide
  • maybe do it

Completion checklist

Event Timeline

ecarg subscribed.

update (in case I forget): we will be doing this rather than another option (i.e. adding flags to builtin functions, etc)

It turns out that we can already do this: the extra ZWrapper.create after a builtin function runs would be a no-op if it received a ZWrapper. It would simply return the ZWrapper intact, including all internal state (which, ultimately, is what we want with this change: the ability to manipulate internal ZWrapper state from within builtin functions).

DSantamaria changed the task status from Open to In Progress.Jan 31 2025, 12:51 PM

@cmassaro Could you please check if this is solved and "resolve" it if that is the case?