Page MenuHomePhabricator

Consider using compareTypes in builtin type checking functions
Closed, ResolvedPublic

Description

Description

This will unify type-checking logic, probably prevent bugs, and possibly obviate an asJSON call.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • don't compare complex Type objects with == or ===; use compareTypes

Completion checklist

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (81ece97)repos/abstract-wiki/wikifunctions/function-evaluator!327jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (81ece97)repos/abstract-wiki/wikifunctions/wikilambda-cli!65jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (8767138)repos/abstract-wiki/wikifunctions/function-orchestrator!304apinesync-function-schematamain
Add isZObject function which finds the first path leading to an invalid object: faster and cheaper than validatesAsZObject!repos/abstract-wiki/wikifunctions/function-schemata!197apineapine-add-bad-pathmain
Customize query in GitLab

Event Timeline

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/197

Add isZObject function which finds the first path leading to an invalid object: faster and cheaper than validatesAsZObject!

Change #1126996 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105

https://gerrit.wikimedia.org/r/1126996

Change #1126996 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-03-05-140247 to 2025-03-11-234105

https://gerrit.wikimedia.org/r/1126996

Change #1128013 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (81ece97)

https://gerrit.wikimedia.org/r/1128013

Change #1128013 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (81ece97)

https://gerrit.wikimedia.org/r/1128013

Change #1129367 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-03-11-234147 to 2025-03-19-125950

https://gerrit.wikimedia.org/r/1129367

Change #1129367 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-03-11-234147 to 2025-03-19-125950

https://gerrit.wikimedia.org/r/1129367

DSantamaria changed the task status from Open to In Progress.Mar 20 2025, 5:59 PM
DSantamaria assigned this task to Jdforrester-WMF.
Jdforrester-WMF subscribed.

I'm not doing this work, Cory was. Is there anything left to do here?