Page MenuHomePhabricator

Upgrade to Gerrit 3.10.4
Closed, ResolvedPublicSecurity

Description

Gerrit 3.10.4 has a fix for T338810 https://www.gerritcodereview.com/3.10.html#3104 :

Issue 365889749: Fix timeouts calculation in SshDaemon

ote: All the SSH timeouts have been broken since the merge of Change 274055 released with Gerrit v3.4.* until v3.9.8. This fix makes the timeouts being considered as documented again, which may result in SSH connections being closed prematurely due to the configured timeouts in gerrit.config.

Related Objects

StatusSubtypeAssignedTask
ResolvedSecurityhashar

Event Timeline

hashar added a parent task: Restricted Task.Jan 13 2025, 5:53 PM
hashar added a project: Gerrit (Gerrit 3.10).
hashar added a subscriber: Paladox.

The reviewers plugin failed to build:

00:09:49.288 [192 / 202] Building plugins/reviewers/libreviewers__plugin-class.jar (19 source files) and running annotation processors (AutoAnnotationProcessor, AutoValueProcessor, AutoOneOfProcessor, AutoValueGsonAdapterFactoryProcessor); 0s remote-cache, multiplex-worker ... (2 actions running)
00:09:49.397 ERROR: /src/plugins/reviewers/BUILD:13:14: Building plugins/reviewers/libreviewers__plugin-class.jar (19 source files) and running annotation processors (AutoAnnotationProcessor, AutoValueProcessor, AutoOneOfProcessor, AutoValueGsonAdapterFactoryProcessor) failed: (Exit 1): java failed: error executing Javac command (from target //plugins/reviewers:reviewers__plugin) external/remotejdk17_linux/bin/java '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED' '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED' ... (remaining 19 arguments skipped)
00:09:49.397 plugins/reviewers/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersResolver.java:102: error: cannot find symbol
00:09:49.397               ? accountResolver.resolveExactIgnoreVisibility(accountName)
00:09:49.397                                ^
00:09:49.397   symbol:   method resolveExactIgnoreVisibility(String)
00:09:49.397   location: variable accountResolver of type AccountResolver
00:09:49.683 Target //plugins/reviewers:reviewers failed to build
00:09:49.683 Use --verbose_failures to see the command lines of failed build steps.
00:09:49.702 INFO: Elapsed time: 4.788s, Critical Path: 1.87s
00:09:49.702 INFO: 20 processes: 18 internal, 1 processwrapper-sandbox, 1 worker.
00:09:49.702 ERROR: Build did NOT complete successfully
00:09:49.734 reviewers failed to build
00:09:49.781 error: pathspec 'plugins/external_package.json' did not match any file(s) known to git

The update has a single change: https://gerrit-review.googlesource.com/c/plugins/reviewers/+/434044 . It is in master, but not in stable-3.10 which is the branch we should track. See https://gerrit-review.googlesource.com/c/plugins/reviewers/+/434044/comments/3d4d4bde_cb4b3393

hashar changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 16 2025, 1:21 PM

I have upgraded Gerrit which addresses the SSH timeout issue.

hashar claimed this task.