Page MenuHomePhabricator
Create Task
Maniphest T383667

Add warning for missing 'preprint' , 'standard', and 'dataset' key in Citoid Extension
Closed, ResolvedPublic
Actions

Description

In 2022 preprint item type was added to Zotero. 'standard' and 'dataset' were added in 2023. We should warn when this key is missing.

https://github.com/zotero/zotero-schema/commit/187305727c5866aef7004fdc8d5ec577a0969bc7

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Warn for missing itemTypesMvolzmediawiki/extensions/Citoidmaster+14 -2
Warn if 'preprint', 'dataset', or 'standard' key is missingMvolzmediawiki/extensions/Citoidmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mvolz created this task.Jan 14 2025, 12:00 PM
Mvolz claimed this task.
gerritbot added a comment.Jan 14 2025, 12:05 PM

Change #1111204 had a related patch set uploaded (by Mvolz; author: Mvolz):

[mediawiki/extensions/Citoid@master] Warn if 'preprint' key is missing

https://gerrit.wikimedia.org/r/1111204

gerritbot added a project: Patch-For-Review.Jan 14 2025, 12:05 PM
Mvolz updated the task description. (Show Details)Jan 14 2025, 1:03 PM
Mvolz renamed this task from Add warning for missing 'preprint' key in Citoid Extension to Add warning for missing 'preprint' and 'dataset' key in Citoid Extension.Jan 16 2025, 12:49 PM
gerritbot added a comment.Jan 16 2025, 3:14 PM

Change #1111204 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Warn if 'preprint', 'dataset', or 'standard' key is missing

https://gerrit.wikimedia.org/r/1111204

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 16 2025, 4:01 PM
Mvolz closed this task as Resolved.Jan 20 2025, 12:13 PM
Mvolz triaged this task as Low priority.
Mvolz updated the task description. (Show Details)
Mvolz reopened this task as Open.Jan 24 2025, 10:59 AM
Mvolz moved this task from Backlog to Extension on the Citoid board.Jan 24 2025, 1:17 PM
Mvolz added a project: VisualEditor-MediaWiki-References.
Mvolz renamed this task from Add warning for missing 'preprint' and 'dataset' key in Citoid Extension to Add warning for missing 'preprint' , 'standard', and 'dataset' key in Citoid Extension.Apr 3 2025, 11:43 AM
gerritbot added a comment.Apr 3 2025, 12:01 PM

Change #1133880 had a related patch set uploaded (by Mvolz; author: Mvolz):

[mediawiki/extensions/Citoid@master] Warn for missing itemTypes

https://gerrit.wikimedia.org/r/1133880

gerritbot added a project: Patch-For-Review.Apr 3 2025, 12:01 PM
gerritbot added a comment.Apr 8 2025, 1:41 PM

Change #1133880 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Warn for missing itemTypes

https://gerrit.wikimedia.org/r/1133880

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15); removed: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Apr 8 2025, 2:00 PM
Mvolz added a project: Editing QA.Apr 9 2025, 11:00 AM
Mvolz added a comment.Apr 9 2025, 11:04 AM
In T383667#10721524, @gerritbot wrote:

Change #1133880 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Warn for missing itemTypes

https://gerrit.wikimedia.org/r/1133880

Adding Editing QA to ensure this change only warns in the console and does not break anything (like it did last time ;))

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2025, 11:29 AM
Ryasmeen edited projects, added: Verified; removed: Editing QA.Apr 18 2025, 12:28 AM
Ryasmeen subscribed.

I can see the warnings in the console on Beta cluster not on en.wiki. Functionality of adding a citation seems to be working fine.

Mvolz added a comment.Apr 18 2025, 10:40 AM
In T383667#10754198, @Ryasmeen wrote:

I can see the warnings in the console on Beta cluster not on en.wiki. Functionality of adding a citation seems to be working fine.

Great. En wiki doesn't have the warnings because they keys aren't missing.

Mvolz closed this task as Resolved.Apr 18 2025, 10:40 AM
Mvolz added projects: Essential-Work, Editing-team (Kanban Board).May 1 2025, 10:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits