Maniphest T383683

Add tests to check for multiple or missing semicolons in strings files
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tsevener
	Jan 14 2025, 2:53 PM

Project Tags

Referenced Files

None

Subscribers

Description

Recently in our manual translations, we had multiple semicolons that caused the syncing with translatewiki to crash (and caused translations to fall back to English). Our PR tests should catch this before we merge.

Write a unit test in TWNStrings.tests.m that:

Loops through all the Wikipedia/Localizations/{langcode}.lproj/Localizable.strings files and counts the number of semicolons at the end of a line. Fail if the count does not equal 1.

Related Objects

Mentioned Here: T386968: Release 7.7.2

Event Timeline

Tsevener created this task.Jan 14 2025, 2:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2025, 2:53 PM

Mazevedo triaged this task as Low priority.Jan 28 2025, 9:09 PM

Mazevedo moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App board.

HNordeenWMF edited projects, added: Wikipedia-iOS-App (Bug Backlog); removed: Wikipedia-iOS-App.Jan 30 2025, 4:05 PM

HNordeenWMF edited projects, added: Wikipedia-iOS-App; removed: Wikipedia-iOS-App (Bug Backlog).

Chandrapg claimed this task.Feb 3 2025, 3:09 AM

Chandrapg edited projects, added: Wikipedia-iOS-App (iOS Release FY2024-25); removed: Wikipedia-iOS-App.Feb 3 2025, 3:16 AM

Chandrapg moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

PR: https://github.com/wikimedia/wikipedia-ios/pull/5184

Tsevener updated the task description. (Show Details)Feb 7 2025, 4:28 PM

PR was merged. Nothing to test for this one, as it only affects unit tests.

Tsevener moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 12 2025, 10:38 PM

Mazevedo removed Chandrapg as the assignee of this task.Feb 18 2025, 6:09 PM

Mazevedo moved this task from Waiting for Build to Ready for PM Signoff on the Wikipedia-iOS-App (iOS Release FY2024-25) board.

Mazevedo added a subscriber: Chandrapg.

Thanks @Chandrapg & @Tsevener for your work on this one!

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App (iOS Release FY2024-25) board.Feb 26 2025, 5:11 PM

This task will be included in release 7.7.2: T386968

HNordeenWMF closed this task as Resolved.Feb 27 2025, 9:47 PM