Page MenuHomePhabricator

Stop GrowthExperiments from creating new user_properties row on signup
Open, MediumPublic

Description

GrowthExperiments currently does this in onLocalUserCreated():

$enablePercentage = $this->config->get( 'GEHomepageNewAccountEnablePercentage' );
if ( rand( 0, 99 ) < $enablePercentage ) {
	$this->userOptionsManager->setOption( $user, self::HOMEPAGE_PREF_ENABLE, 1 );
	$this->userOptionsManager->setOption( $user, self::HOMEPAGE_PREF_PT_LINK, 1 );
	// [...]
}

At least some of those calls can be replaced with an appropriate conditional defaults configuration. In order to do our part with T54777: user_properties table bloat, we should move to conditional defaults for this need.

Event Timeline

Change #1111323 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] HomepageHooksTest: Verify appropriate user properties are set on signup

https://gerrit.wikimedia.org/r/1111323

Change #1111323 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] HomepageHooksTest: Verify appropriate user properties are set on signup

https://gerrit.wikimedia.org/r/1111323