Page MenuHomePhabricator

[jobs-api] treat URLs with and without a trailing slash the same
Closed, ResolvedPublic

Description

Jobs-api currently has routes with trailing slashes, and will treat the same route without the expected slash as a different endpoint.

With the future consolidated toolforge cli in mind, we'd like jobs-api to behave like the other toolforge apis, i.e. not require trailing slashes. For backward compatibility reasons however, we do want trailing slashes to also work.

So e.g. /v1/tool/some-tool/images and /v1/tool/some-tool/images/ should work the same.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
api: make trailing slash optionalrepos/cloud/toolforge/jobs-api!137sstefanovaslavina/make-trailing-slash-optionalmain
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Slst2020 changed the task status from Open to In Progress.Jan 15 2025, 5:30 PM
Andrew triaged this task as Medium priority.Jan 15 2025, 11:23 PM

group_203_bot_4866fc124f4b41659f667468a6115cf3 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/680

jobs-api: bump to 0.0.355-20250227153935-4a76dc7c

dcaro moved this task from In Progress to Done on the Toolforge (Toolforge iteration 18) board.