Page MenuHomePhabricator

Store Add Link did not generate any recommendation for a page
Closed, DuplicatePublic

Description

From T378527#10384905 (and T382270):

Can we somehow store the information that we did not find any suggestions for a page? Currently we just plain do nothing in that case and we then try again the next time around. It would be nice to be able to skip that extra work by somewhere (page prop? cirrus search weighted tag? GE-specific db entry? ...?) storing that for the combination of page-revisionID + community-config-hash (+ model number?) we did not have any suggestion, so we do not need to try again.

Today we discussed this task and how to move forward with the related approach of generating more suggestions (T378527, T378536 and T382404). We concluded that implementing the feature discussed in this task here would be highly benefitting, regardless of which approach is ultimately picked.

We decided that the easiest way to implement this is to alter the existing growthexperiments_link_recommendations table and to make the gelr_data field nullable. That field being null would then be interpreted as that we tried to get a recommendation for a page from the service but did not succeed. Such a row would usually be removed by the existing process when a page has been edited or through revalidation (currently implemented via a manual maintenance script).