Standardized header: Places
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	HNordeenWMF
	Jan 15 2025, 9:10 PM

Description

Background

As part of the ongoing Navigation refresh, we are standardizing the design of the headers throughout the app on iPhone and iPad, to standardize and allow room for upcoming features.

Requirements

Add access to profile onto Places view (ignore Tabs icon for now)
Update header design to match Figma
The header should remain sticky when user scrolls within map, or list view (different from other main views)
Must function on both iPhone and iPad
Must function in Landscape mode

Designs (for reference, check Figma for most up-to-date)

iPhone	iPad

Related Objects
Search...

Status	Assigned	Task
Open	None	T373712 [Epic] iOS Navigation Refresh
Resolved	HNordeenWMF	T379440 [Sub-Epic] Navigation Refresh Part 2 - Search Improvements - Jan/Feb 2025
Resolved	None	T383821 Standardized header: Places

Event Timeline

HNordeenWMF created this task.Jan 15 2025, 9:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2025, 9:10 PM

HNordeenWMF triaged this task as Low priority.Jan 15 2025, 9:11 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF updated the task description. (Show Details)Jan 15 2025, 9:17 PM

HNordeenWMF updated the task description. (Show Details)

HNordeenWMF updated the task description. (Show Details)Jan 15 2025, 9:23 PM

HNordeenWMF mentioned this in T379440: [Sub-Epic] Navigation Refresh Part 2 - Search Improvements - Jan/Feb 2025.Jan 15 2025, 10:25 PM

HNordeenWMF updated the task description. (Show Details)Jan 16 2025, 6:37 PM

HNordeenWMF updated the task description. (Show Details)

Tsevener renamed this task from Standardized header: Places to [S] Standardized header: Places.Jan 16 2025, 7:08 PM

HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 16 2025, 8:19 PM

Seddon renamed this task from [S] Standardized header: Places to Standardized header: Places.Jan 17 2025, 1:10 AM

Seddon set the point value for this task to 1.

Mazevedo moved this task from Ready for future sprints to Current Sprint Work on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 21 2025, 6:33 PM

Mazevedo claimed this task.Jan 22 2025, 3:05 PM

Mazevedo moved this task from Current Sprint Work to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

mazevedofs opened https://github.com/wikimedia/wikipedia-ios/pull/5165

Mazevedo moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 23 2025, 3:49 PM

Mazevedo added a project: iOS Sprint 2025: Cairo.Jan 23 2025, 5:23 PM

Tsevener moved this task from Needs Code Review to Did not pass Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 23 2025, 8:35 PM

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5165

Tsevener moved this task from Did not pass Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Jan 24 2025, 2:15 PM

Can be tested on 7.7.1 (4905)

Looks good on 7.7.1 (4912)

Looks good to me, sending back for quick design check

Just noticed a minor difference in the search bar regarding icon spacing and label consistency @Mazevedo (compare to the one in Explore, Saved or Search):

Places	vs	Search (for example)

Spacing between icon + label is too large (see the other search bars as reference)
Consistent sentence case label: Search places as opposed to Search Places

Thanks!

• scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 10 2025, 9:10 PM

• scblr moved this task from Needs Code Review to Did not pass design review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 10 2025, 9:14 PM

• scblr attached a referenced file: F58384176: IMG_1008.PNG. (Show Details)Feb 10 2025, 10:13 PM

• scblr attached a referenced file: F58384181: IMG_1007.PNG. (Show Details)

Already have a task for that fix! T383464

@scblr @HNordeenWMF - the spacing issue seems to be the component adjusting the text to the space available - in the screenshots below, in Portuguese, the text is longer on both screens, and the spacing is consistent. We have no control over that part of the component in this case.

Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.41.png (2×1 px, 155 KB)

Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.33.png (2×1 px, 1 MB)

In T383821#10537141, @Mazevedo wrote:

@scblr @HNordeenWMF - the spacing issue seems to be the component adjusting the text to the space available - in the screenshots below, in Portuguese, the text is longer on both screens, and the spacing is consistent. We have no control over that part of the component in this case.

Hmm, this is weird! It doesn’t adjust the space in current production! ⬇️

C3916FD2-C828-4527-A5E6-EFE1F000310A_1_102_o.jpeg (2×1 px, 226 KB)

0847C16A-0DB7-4E91-A776-35B146AA0433_1_102_o.jpeg (2×1 px, 619 KB)

I checked French and German in Experimental build 7.7.1.221 , where the problem (gap between icon + label) is occurring as well with various string lengths:

In Portuguese (Brazil) as well on my device! ⬇️ 🤔

In T383821#10537115, @HNordeenWMF wrote:

Already have a task for that fix! T383464

Thx Haley – oversaw that 🙈

• scblr mentioned this in T383464: System Nav Bar [Design Review] - Places search fixes.Feb 11 2025, 10:46 AM

HNordeenWMF moved this task from Ready for PM Signoff to Ready for Release on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Feb 11 2025, 8:39 PM

HNordeenWMF closed this task as Resolved.Feb 13 2025, 3:36 PM

HNordeenWMF removed Mazevedo as the assignee of this task.

HNordeenWMF added a subscriber: Mazevedo.

	F58385402: 0847C16A-0DB7-4E91-A776-35B146AA0433_1_102_o.jpeg
	Feb 11 2025, 10:44 AM

	F58385404: C3916FD2-C828-4527-A5E6-EFE1F000310A_1_102_o.jpeg
	Feb 11 2025, 10:44 AM

	F58384292: Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.33.png
	Feb 10 2025, 10:43 PM

	F58384290: Simulator Screenshot - iPhone 16 - 2025-02-10 at 19.39.41.png
	Feb 10 2025, 10:43 PM

Standardized header: PlacesClosed, ResolvedPublic1 Estimated Story PointsActions