iPad floating tab bar search icon
Open, LowPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	HNordeenWMF
	Jan 15 2025, 10:19 PM

Description

Background

As part of the ongoing Navigation refresh, we are standardizing the design of the headers throughout the app on iPhone and iPad, to standardize and allow room for upcoming features. There are several improvements specific to the iPad floating toolbar, which displays on all views of the app currently.

Requirements

Replace "Search" title in toolbar with magnifying glass icon from SF Symbols
Match design to figma

Designs

Figma

Engineering Notes

TS - See Apple documentation on how to do this. We need to set AppViewController's tabs property, and use a UISearchTab for the final tab. Re-check all programatic navigation after doing this. The last time I tried this, search results navigation broke (see https://phabricator.wikimedia.org/T363606#10408281).

Related Objects
Search...

Status	Assigned	Task
Open	None	T373712 [Epic] iOS Navigation Refresh
Open	None	T379440 [Sub-Epic] Navigation Refresh Part 2 - Search Improvements - Jan/Feb 2025
Open	Chandrapg	T383831 iPad floating tab bar search icon

Event Timeline

HNordeenWMF created this task.Jan 15 2025, 10:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2025, 10:19 PM

HNordeenWMF updated the task description. (Show Details)Jan 15 2025, 10:19 PM

HNordeenWMF triaged this task as Low priority.Jan 15 2025, 10:22 PM

HNordeenWMF moved this task from Tasks from Product Backlog to Needs Eng Sync or Estimation on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

HNordeenWMF mentioned this in T379440: [Sub-Epic] Navigation Refresh Part 2 - Search Improvements - Jan/Feb 2025.Jan 15 2025, 10:25 PM

HNordeenWMF merged a task: T383462: System Nav Bar [Design Review] - Use "Search" magnifying glass icon instead of text for iPad.Jan 15 2025, 10:36 PM

HNordeenWMF added a subscriber: Tsevener.

Tsevener renamed this task from iPad floating tab bar search icon to [L] iPad floating tab bar search icon.Jan 16 2025, 7:13 PM

HNordeenWMF mentioned this in T383470: System Nav Bar [Design Review] - Add larger top overlay background for iPad floating tab bar.Jan 16 2025, 8:08 PM

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog; removed Wikipedia-iOS-App-Backlog (iOS Release FY2024-25).Jan 16 2025, 8:22 PM

HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.

HNordeenWMF updated the task description. (Show Details)Jan 17 2025, 3:37 PM

Tsevener updated the task description. (Show Details)Jan 21 2025, 5:29 PM

HNordeenWMF moved this task from Up next to iOS Release FY2024-25 on the Wikipedia-iOS-App-Backlog board.Jan 22 2025, 9:18 PM

HNordeenWMF edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2024-25); removed Wikipedia-iOS-App-Backlog.

HNordeenWMF moved this task from Needs Eng Sync or Estimation to Ready for future sprints on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Mazevedo renamed this task from [L] iPad floating tab bar search icon to iPad floating tab bar search icon.Jan 23 2025, 6:31 PM

Mazevedo set the point value for this task to 5.

Chandrapg subscribed.Feb 9 2025, 12:42 AM

@HNordeenWMF Is the change specific to iPad? I'm assuming yes but wanted to confirm.

I made a change and it seems to be working on iPad but its broken on iPhone.

Also I've fixed the issue mentioned in the engineering notes section in description of the task.

Here's the demo

SearchTab.mov1 MBDownload

Hi @Chandrapg - correct, this should only be changed on iPad.
I'm unable to see the demo :/ could you try attaching the file again? Sometimes you need to check the top-right-section "Referenced Files" of the task and "Attach file" if it's showing in red.

@HNordeenWMF Re-Attached demo.

SearchTab.mov1 MBDownload

@Chandrapg Nice! This is looking good to me so far. Can you put up a PR so we can dig into it further? Thank you!

PR: https://github.com/wikimedia/wikipedia-ios/pull/5202

I've tested regular scenarios like searching in every tab, switching tabs on iPad and also verified on iPhone that we don't use these changes. But I'm sure I might have missed other areas.

Chandrapg claimed this task.Feb 15 2025, 10:23 PM

Chandrapg moved this task from Ready for future sprints to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.

Tsevener added a project: iOS Sprint 2025: Egypt.Tue, Feb 18, 11:27 PM

@scblr This will be in Experimental build 7.7.2 (224) for design review.

Tsevener moved this task from Needs Code Review to Design signoff on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Thu, Feb 20, 8:30 PM

Looks and works well from a design perspective — thanks @Chandrapg and @Tsevener 👏

scblr moved this task from Design signoff to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2024-25) board.Mon, Mar 3, 11:49 AM

	F58383789: SearchTab.mov
	Feb 10 2025, 5:40 PM

	F58379557: SearchTab.mov
	Feb 9 2025, 2:31 AM

iPad floating tab bar search iconOpen, LowPublic5 Estimated Story PointsActions