Page MenuHomePhabricator

System Nav Bar [Design Review] - Remove Article W logo on iPad
Closed, ResolvedPublic3 Estimated Story Points

Description

We want to remove the Article W logo on iPadOS 18. When

Ensure W icon tooltip no longer displays for iPadOS 18 as well.

When we pick up T383836, users will be able to tap the tab bar to pop back to the root.

Event Timeline

Tsevener renamed this task from [System Nav Bar] Change article logo to full logo, left aligned for iPad to System Nav Bar [Design Review] - Change article logo to full logo, left aligned for iPad.Jan 15 2025, 11:17 PM
Mazevedo set the point value for this task to 3.Jan 23 2025, 6:28 PM

Note: See progress branch on custom font for large title nav bar logo in https://phabricator.wikimedia.org/T383471#10459200.

@scblr From my explorations today, it's looking like a large, left-aligned title on article view will not work well and I advise that we don't pursue this task, or alter the article nav bar in a different way. Here are the issues I'm running against. I have linked my explorations in Google Drive.

  1. When pushing on a view controller configured with a large title on iPadOS18, there's an awkward extra space that is added to the top that I cannot control. I think this is a bug on Apple's side, as I experience the same thing in a very simple sample project. See videos 1 and 2 spacing.
  2. I cannot attach a tap gesture to the large title, so I will be unable to pop the navigation back to the root when tapping it.
  3. The article with a large title has awkward hide handling when scrolling the table of contents vs the article view. My guess is the system navigation bar is unsure of which scroll view to listen to while scrolling, and so far I'm having trouble controlling that. (All of our other views only use a single scroll view, so it's less of an issue). See video 1. I may be able to deconstruct it and rework table of contents entirely to try and control it better, but I'm not sure that work is worth it given the problems in #1 and #2.

I did explore hiding the W icon entirely, to give Article as much space as possible. I realize we will lose some branding but I think it's something worth considering. See video 5. If we allow tapping of the tab bar item to pop back to the root, then the W icon tap behavior becomes redundant anyway.

I did explore hiding the W icon entirely, to give Article as much space as possible. I realize we will lose some branding but I think it's something worth considering. See video 5. If we allow tapping of the tab bar item to pop back to the root, then the W icon tap behavior becomes redundant anyway.

@Tsevener I agree with this approach 👍 Let’s discuss this in our call later today.

Tsevener renamed this task from System Nav Bar [Design Review] - Change article logo to full logo, left aligned for iPad to System Nav Bar [Design Review] - Remove Article W logo on iPad.Feb 4 2025, 9:24 PM
Tsevener updated the task description. (Show Details)

@scblr FYI, updated the task description to reflect what we last talked about. I will make an official design review build for your final review soon. Thanks!

@scblr Ok, this is in Experimental build 7.7.1 (220) for design review.

I just checked, and it looks good without the logo! 👍 thx for the work

HNordeenWMF removed Tsevener as the assignee of this task.