Page MenuHomePhabricator

Highlight current block row when editing or removing
Closed, ResolvedPublic3 Estimated Story Points

Assigned To
Authored By
Samwilson
Jan 16 2025, 12:34 AM
Referenced Files
F58441532: 2025-02-21_00-34-51.png
Feb 21 2025, 5:18 PM
F58441458: 2025-02-21_00-12-34.mp4.gif
Feb 21 2025, 5:18 PM
F58441451: 2025-02-21_00-13-32.mp4.gif
Feb 21 2025, 5:18 PM
F58441505: 2025-02-21_00-18-02.mp4.gif
Feb 21 2025, 5:18 PM
F58441478: 2025-02-20_21-33-04.mp4.gif
Feb 21 2025, 5:18 PM
F58441467: 2025-02-21_00-10-46.mp4.gif
Feb 21 2025, 5:18 PM
F58441471: 2025-02-21_00-08-21.mp4.gif
Feb 21 2025, 5:18 PM
F58441439: 2025-02-21_00-17-21.mp4.gif
Feb 21 2025, 5:18 PM

Description

When a block is being edited (in the form below) or removed (with the dialog open), the row in question should be highlighted with a background color of #dce3f9 (using the appropriate Codex variable, of course).

image.png (413×599 px, 40 KB)

Derived Requirement

Ensure that when a block is being edited or removed, the corresponding row is highlighted with a background color of #dce3f9 (using the appropriate Codex variable) to visually indicate the active row.

Test Steps

Test Case 1: Ensure Row is Highlighted When Editing or Removing a Block

  1. Navigate to the block management interface (e.g., the "Special:Block" form).
  2. Select a block to edit and open the editing form.
  3. Verify that the row containing the block is highlighted with a background color of #dce3f9 during the editing process.
  4. Open the dialog to remove the selected block.
  5. Verify that the row containing the block to be removed is highlighted with a background color of #dce3f9 while the dialog is open.
  6. ✅❓❌⬜ AC1: Confirm that the row of the block being edited or removed is highlighted with a background color of #dce3f9.

QA Results - Test Wiki

ACStatusDetails
1T383846#10571711

Event Timeline

Change #1115155 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: Highlight selected block row

https://gerrit.wikimedia.org/r/1115155

Change #1115155 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: Highlight selected block row

https://gerrit.wikimedia.org/r/1115155

@HMonroy The background color matches #dce3f9. When I go to Contributions or Blocklist, it forms an ID# in the URL, and that doesn't highlight the block as seen in the gifs below. If the ID# is not in the URL, I can highlight.

Test Result - TestWiki

Status: ❌ FAIL
Environment: TestWiki
OS: macOS Sonoma 15.3
Browser: Chrome 132
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/Betatesterone
https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/Betatesterone&id=336

Test Steps

Test Case 1: Ensure Row is Highlighted When Editing or Removing a Block

  1. Navigate to the block management interface (e.g., the "Special:Block" form).
  2. Select a block to edit and open the editing form.
  3. Verify that the row containing the block is highlighted with a background color of #dce3f9 during the editing process.
  4. Open the dialog to remove the selected block.
  5. Verify that the row containing the block to be removed is highlighted with a background color of #dce3f9 while the dialog is open.
  6. AC1: Confirm that the row of the block being edited or removed is highlighted with a background color of #dce3f9.

TestWIki

✅ Background Color❌Contributions❌Blocklist
2025-02-06_12-40-36.mp4.gif (850×1 px, 2 MB)
2025-02-06_12-38-14.mp4.gif (782×1 px, 1 MB)
2025-02-06_12-39-14.mp4.gif (838×1 px, 1 MB)

Local does the same thing in TestWiki

2025-02-06_12-50-31.mp4.gif (826×1 px, 1 MB)

Change #1117999 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: Fix highlighting when block id is set in url

https://gerrit.wikimedia.org/r/1117999

Change #1117999 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: Fix highlighting when block id is set in url

https://gerrit.wikimedia.org/r/1117999

@HMonroy The background color matches #dce3f9. When I go to Contributions or Blocklist, it forms an ID# in the URL, and that doesn't highlight the block as seen in the gifs below. If the ID# is not in the URL, it will highlight the block.

Test Result - Local
Status: ❌ FAIL
Environment: Local 1.44.0-alpha (6f095ac) 16:22, 11 February 2025; ContentTranslation: – (8b76a8d) 14:55, 11 February 2025
OS: macOS Sonoma 15.3
Browser: Chrome 132
Device: MBA
Emulated Device: NA

Test Artifact(s):
Local- Special:Block
Local- Special:Blocklist

Test Steps

Test Case 1: Ensure Row is Highlighted When Editing or Removing a Block

  1. Navigate to the block management interface (e.g., the "Special:Block" form).
  2. Select a block to edit and open the editing form.
  3. Verify that the row containing the block is highlighted with a background color of #dce3f9 during the editing process.
  4. Open the dialog to remove the selected block.
  5. Verify that the row containing the block to be removed is highlighted with a background color of #dce3f9 while the dialog is open.
  6. AC1: Confirm that the row of the block being edited or removed is highlighted with a background color of #dce3f9.

Local

❌Contributions❌Blocklist
2025-02-11_13-00-39.mp4.gif (826×1 px, 1 MB)
2025-02-11_13-01-19.mp4.gif (826×1 px, 1 MB)

Change #1119132 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: Fix highlighting when url id is set

https://gerrit.wikimedia.org/r/1119132

JWheeler-WMF changed the point value for this task from 5 to 3.

Change #1119132 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: Fix highlighting when url id is set

https://gerrit.wikimedia.org/r/1119132

MusikAnimal subscribed.

QA note: The row in the Active Blocks table stays highlighted after a successful block. This is being fixed separately as part of T384822: Codex Special:Block: Form not being reset properly.

@HMonroy The background color matches #dce3f9. Confirmed that the row of the block being edited or removed is highlighted. Even when I go to Contributions or Blocklist, it forms an ID# in the URL as seen in the gifs. I will Resolve this. Thanks for all your work!

Test Result - Local
Status: ✅ PASS
Environment: 1.44.0-alpha (3fbb348) 16:45, 20 February 2025 ContentTranslation: – (aca675c) 16:27, 20 February 2025
OS: macOS Sonoma 15.3.1
Browser: Chrome 133, Firefox 135, Safari 18.3
Device: MBA
Emulated Device: NA

Test Artifact(s):
Local- Special:Block
Local- Special:Blocklist

Test Steps

Test Case 1: Ensure Row is Highlighted When Editing or Removing a Block

  1. Navigate to the block management interface (e.g., the "Special:Block" form).
  2. Select a block to edit and open the editing form.
  3. Verify that the row containing the block is highlighted with a background color of #dce3f9 during the editing process.
  4. Open the dialog to remove the selected block.
  5. Verify that the row containing the block to be removed is highlighted with a background color of #dce3f9 while the dialog is open.
  6. AC1: Confirm that the row of the block being edited or removed is highlighted with a background color of #dce3f9.

Local

SpecialChrome- VectorChrome- MinervaFirebox- MonobookSafari- Timeless
Contribution
2025-02-21_00-15-47.mp4.gif (942×1 px, 2 MB)
2025-02-21_00-17-21.mp4.gif (938×1 px, 1 MB)
2025-02-21_00-08-21.mp4.gif (944×1 px, 1 MB)
2025-02-21_00-10-46.mp4.gif (838×838 px, 2 MB)
Blocklist
2025-02-20_21-33-04.mp4.gif (940×1 px, 2 MB)
2025-02-21_00-18-02.mp4.gif (938×1 px, 2 MB)
2025-02-21_00-13-32.mp4.gif (936×1 px, 3 MB)
2025-02-21_00-12-34.mp4.gif (828×856 px, 2 MB)

background color matches #dce3f9

2025-02-21_00-34-51.png (905×1 px, 370 KB)

GMikesell-WMF updated the task description. (Show Details)