Page MenuHomePhabricator

Show temporary accounts onboarding dialog by default on all wikis except for WMF wikis
Closed, ResolvedPublic

Description

The temporary accounts onboarding dialog needs to be enabled by default so that we can create a selenium test that verifies the IPInfo preference check works for the dialog. However, we need to keep the dialog disabled on WMF wikis while we finish up development work on it, as once the user has seen the dialog once we don't show it to them again (so if it's improved the user won't see those improvements).

Acceptance criteria
  • Enable by default the temporary accounts onboarding dialog, but disable it for all WMF wikis

Event Timeline

Change #1112209 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Pin wgCheckUserEnableTempAccountsOnboardingDialog as false

https://gerrit.wikimedia.org/r/1112209

Change #1112211 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Enable the onboarding dialog in extension.json

https://gerrit.wikimedia.org/r/1112211

Change #1112209 merged by jenkins-bot:

[operations/mediawiki-config@master] Pin wgCheckUserEnableTempAccountsOnboardingDialog as false

https://gerrit.wikimedia.org/r/1112209

Change #1112211 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Enable the onboarding dialog in extension.json

https://gerrit.wikimedia.org/r/1112211

@Dreamy_Jazz we might want to disable this on Patch Demo, what do you think?

@Dreamy_Jazz we might want to disable this on Patch Demo, what do you think?

We could do that, though I was intending to make the config variable that controls this temporary + it would make testing this not possible on patch demo.

Perhaps, instead the preference could be set by default to have seen the dialog? Then when testing a user could set the preference to not seen to see the dialog.

@Dreamy_Jazz we might want to disable this on Patch Demo, what do you think?

We could do that, though I was intending to make the config variable that controls this temporary + it would make testing this not possible on patch demo.

Perhaps, instead the preference could be set by default to have seen the dialog? Then when testing a user could set the preference to not seen to see the dialog.

Filed T385708 for this.